Uh oh!
There was an error while loading. Please reload this page.
gh-104389: Add 'unused' keyword to Argument Clinic C converters - #104390
Merged
Conversation
Use the unused keyword param in the converter to explicitly mark an argument as unused: /*[clinic input] BaseClass.interface flag: bool(unused=True)
erlend-aasland
commented
May 11, 2023
ContributorAuthor
The _io change is to show the feature; we can revert it before landing. |
vstinner
commented
May 11, 2023
Member
Do you have at least one use case for this addition? |
vstinner
approved these changes
May 11, 2023
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. It would be nice to have directly an user of this feature, but I'm fine with adding support for it, and later have a separated PR using it. I see where you will use it in the _io extension ;-)
erlend-aasland
commented
May 12, 2023
ContributorAuthor
Yes, I'll create PRs for usage quite soon :) Anyway, I got two approvals here, a couple of thumbs up on the PR, five likes on the Discourse topic. I'll land this soon. |
erlend-aasland
commented
May 12, 2023
ContributorAuthor
PR for _io usage: |
bedevere-bot
commented
May 12, 2023
|
carljm added a commit
to carljm/cpython
that referenced
this pull request
May 12, 2023
* main: pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422) pythonGH-104371: check return value of calling `mv.release` (python#104417) pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416) pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863) pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387) pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403) pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390) pythongh-101819: Prepare _io._IOBase for module state (python#104386) pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414) Fix refleak in `super_descr_get` (python#104408) pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700) pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294) pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378) pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394) pythongh-104392: Remove _paramspec_tvars from typing (python#104393) pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397) pythongh-99108: Refresh HACL* from upstream (python#104401) pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
erlend-aasland added a commit
to erlend-aasland/devguide
that referenced
this pull request
Sep 8, 2023
…erters (python/cpython#104390) Use the unused keyword param in the converter to explicitly mark an argument as unused: /*[clinic input] SomeBaseClass.stubmethod flag: bool(unused=True) [clinic start generated code]*/
AA-Turner pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Sep 13, 2023
…erters (python/cpython#104390) Use the unused keyword param in the converter to explicitly mark an argument as unused: /*[clinic input] SomeBaseClass.stubmethod flag: bool(unused=True) [clinic start generated code]*/
erlend-aasland added a commit
to python/devguide
that referenced
this pull request
Sep 26, 2023
…erters (python/cpython#104390) Use the unused keyword param in the converter to explicitly mark an argument as unused: /*[clinic input] SomeBaseClass.stubmethod flag: bool(unused=True) [clinic start generated code]*/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the unused keyword param in the converter to explicitly
mark an argument as unused:
📚 Documentation preview 📚: https://cpython-previews--104390.org.readthedocs.build/