Skip to content

gh-104482: Fix error handling bugs in ast.c - #104483

Merged
iritkatriel merged 11 commits into
python:mainfrom
iritkatriel:missingBreak
May 15, 2023
Merged

gh-104482: Fix error handling bugs in ast.c#104483
iritkatriel merged 11 commits into
python:mainfrom
iritkatriel:missingBreak

Conversation

@iritkatriel

@iritkatrieliritkatriel commented May 14, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request May 14, 2023
Closed
@iritkatriel

iritkatriel commented May 14, 2023

Copy link
Copy Markdown
MemberAuthor

I don't know if you want to add more tests for this - the assertion I added would fail without this fix.

iritkatriel
iritkatriel commented May 14, 2023
View reviewed changes
Comment threadPython/ast.c Outdated
@iritkatrieliritkatriel added type-bug An unexpected behavior, bug, or error needs backport to 3.11 only security fixes labels May 14, 2023
@furkanonder

furkanonder commented May 15, 2023

Copy link
Copy Markdown
Contributor

CC: @isidentical

isidentical
isidentical approved these changes May 15, 2023
View reviewed changes
Comment threadPython/compile.c
iritkatriel
iritkatriel commented May 15, 2023
View reviewed changes
Comment threadPython/ast.c
carljm
carljm reviewed May 15, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2023-05-14-18-56-54.gh-issue-104482.yaQsv8.rst Outdated
Comment threadPython/ast.c
iritkatriel
iritkatriel commented May 15, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2023-05-14-18-56-54.gh-issue-104482.yaQsv8.rst Outdated
iritkatriel
iritkatriel commented May 15, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2023-05-14-18-56-54.gh-issue-104482.yaQsv8.rst Outdated
@iritkatriel

iritkatriel commented May 15, 2023

Copy link
Copy Markdown
MemberAuthor

The hypothesis bot fails everywhere. We’re good.

@iritkatriel
iritkatriel merged commit 8a3702f into python:mainMay 15, 2023
@miss-islington

miss-islington commented May 15, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 15, 2023

Copy link
Copy Markdown
Contributor

Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8a3702f0c79e5a99fcef61e35724f4b9ea3453b8 3.11

@iritkatrieliritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 15, 2023
@iritkatrieliritkatriel mentioned this pull request May 15, 2023
Merged
carljm added a commit to carljm/cpython that referenced this pull request May 16, 2023
@carljm
Merge branch 'main' into supermon
a6dd626
* main:
pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
pythongh-64595: Fix write file logic in Argument Clinic (python#104507)
pythongh-104523: Inline minimal PGO rules (python#104524)
pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)
pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)
pythongh-103763: Implement PEP 695 (python#103764)
pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)
pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)
pythongh-104482: Fix error handling bugs in ast.c (python#104483)
pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)
pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
@iritkatriel
iritkatriel deleted the missingBreak branch July 25, 2023 18:03
@ZeroIntensityZeroIntensity removed type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.11 only security fixes labels Feb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes
@isidenticalisidenticalisidentical approved these changes
@brandtbucherbrandtbucherAwaiting requested review from brandtbucher
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

@iritkatrieliritkatriel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error handling bugs in ast.c

7 participants

@iritkatriel@furkanonder@miss-islington@carljm@isidentical@bedevere-bot@ZeroIntensity