Skip to content

gh-104469 Convert _testcapi/exceptions to use AC - #104502

Merged
corona10 merged 6 commits into
python:mainfrom
corona10:gh-104469-exceptions
May 21, 2023
Merged

gh-104469 Convert _testcapi/exceptions to use AC#104502
corona10 merged 6 commits into
python:mainfrom
corona10:gh-104469-exceptions

Conversation

@corona10

@corona10corona10 commented May 15, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request May 15, 2023
Closed
@corona10corona10 mentioned this pull request May 15, 2023
Merged
@corona10

corona10 commented May 17, 2023

Copy link
Copy Markdown
MemberAuthor

@erlend-aasland@sobolevn Would you like to take a look?

sobolevn
sobolevn reviewed May 17, 2023
View reviewed changes
Comment threadModules/_testcapi/exceptions.c
Comment threadModules/_testcapi/exceptions.c
@corona10
corona10 requested a review from sobolevnMay 18, 2023 01:01
@corona10

corona10 commented May 18, 2023

Copy link
Copy Markdown
MemberAuthor

@sobolevn Thanks! Updated!

erlend-aasland
erlend-aasland reviewed May 18, 2023
View reviewed changes
Comment threadModules/_testcapi/exceptions.c Outdated
Comment threadModules/_testcapi/exceptions.c Outdated
@corona10

corona10 commented May 19, 2023

Copy link
Copy Markdown
MemberAuthor

@erlend-aasland Thanks! PTAL one more time!

@corona10
corona10 merged commit 2e91c7e into python:mainMay 21, 2023
@corona10
corona10 deleted the gh-104469-exceptions branch May 21, 2023 09:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@sobolevn@erlend-aasland@bedevere-bot