Skip to content

gh-104539: Fix indentation error in logging.config.rst - #104540

Closed
jnoordsij wants to merge 1 commit into
python:3.11from
jnoordsij:patch-1
Closed

gh-104539: Fix indentation error in logging.config.rst#104540
jnoordsij wants to merge 1 commit into
python:3.11from
jnoordsij:patch-1

Conversation

@jnoordsij

@jnoordsijjnoordsij commented May 16, 2023

Copy link
Copy Markdown
Contributor

I think this should solve #104539, but I'm not entirely sure.


📚 Documentation preview 📚: https://cpython-previews--104540.org.readthedocs.build/

@jnoordsij
jnoordsij requested a review from vsajip as a code ownerMay 16, 2023 10:58
@ghost

ghost commented May 16, 2023

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk

Copy link
Copy Markdown
Member

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!

@hugovk
hugovk removed the request for review from vsajipMay 16, 2023 11:10
@vsajip

Copy link
Copy Markdown
Member

I'll close this, and wait for the patch against the main branch.

@vsajipvsajip closed this May 16, 2023
@jnoordsij

Copy link
Copy Markdown
ContributorAuthor

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!

Ah that makes sense! Will open a new PR soon.

@jnoordsij
jnoordsij deleted the patch-1 branch May 16, 2023 11:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewdocsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jnoordsij@hugovk@vsajip@bedevere-bot