gh-103921: Document PEP 695 by JelleZijlstra · Pull Request #104642 · python/cpython

JelleZijlstra · 2023-05-19T04:23:26Z

Issue: Document PEP 695 #103921

📚 Documentation preview 📚: https://cpython-previews--104642.org.readthedocs.build/

hugovk · 2023-05-19T10:01:42Z

You could add this PEP to the release highlights: https://docs.python.org/3.12/whatsnew/3.12.html#summary-release-highlights

AlexWaygood

I'd like us to explicitly state somewhere that typing.TypeAliasType is not the type of typing.TypeAlias (and that in fact, they basically don't compose at all). I feel like this will inevitably cause confusion otherwise.

This allows :keyword:`type` to link to docs for the new `type` statement (being written in pythongh-104642) instead of to this header in the argparse docs.

This allows :keyword:`type` to link to docs for the new `type` statement (being written in gh-104642) instead of to this header in the argparse docs.

AlexWaygood

Other than #104642 (comment) and one tiny last nit, this looks fantastic. Thanks for the huge amount of effort here, and for putting up with my many rounds of review!

AlexWaygood · 2023-05-26T16:44:55Z

-of (str, str) -> str and (bytes, bytes) -> bytes. Also note\n\
-that if the arguments are instances of some subclass of str,\n\
-the return type is still plain str.\n\
 \n\


Don't think two line breaks are necessary here
Suggested change
\n\

Thanks, fixed.
Also thanks for all the thorough reviews! I am going to merge this now so I can stop worrying about conflicts.

Yup, it's time :)

miss-islington · 2023-05-26T17:48:21Z

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

(cherry picked from commit 060277d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot · 2023-05-26T17:48:32Z

GH-104989 is a backport of this pull request to the 3.12 branch.

carljm · 2023-05-26T17:49:05Z

🎉

AlexWaygood · 2023-05-26T17:50:08Z

🥳🚀

(cherry picked from commit 060277d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>. (cherry picked from commit 060277d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

bedevere-bot · 2023-05-27T01:26:03Z

GH-105007 is a backport of this pull request to the 3.11 branch.

AlexWaygood · 2023-05-27T10:04:53Z

 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

-.. class:: FunctionDef(name, args, body, decorator_list, returns, type_comment)
+.. class:: FunctionDef(name, type_params, args, body, decorator_list, returns, type_comment)


Just realised that type_params is in the wrong place here for the AST as it currently exists on main, where type_params is at the end. But probably not worth fixing that until questions about the ABI are resolved in #104974.

Also, looks like you might have added type_params to the constructor for FunctionDef and ClassDef, but not AsyncFunctionDef!

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

JelleZijlstra added 4 commits May 13, 2023 05:56

First docs work
786a436

More words
c1f266e

Merge remote-tracking branch 'upstream/main' into pep695docs
040c4fd

ast changes, fix build
e3dfb27

JelleZijlstra added skip news topic-typing labels May 19, 2023

bedevere-bot mentioned this pull request May 19, 2023
Document PEP 695 #103921
Closed
9 tasks

bedevere-bot added the docs Documentation in the Doc dir label May 19, 2023

JelleZijlstra added 10 commits May 18, 2023 21:25

the big PEP list
f5b1d86

dis
5798631

default roles
0f76679

TODOs in compound_stmts
cb76021

minor
12c1249

Remove broken link
94a4da2

update dis.dis docs
815a021

TypeAlias is deprecated
17ac785

Type aliases should now use the type statement
1311399

syntax
123752c

AlexWaygood reviewed May 19, 2023
View reviewed changes

Comment threadDoc/library/argparse.rst

AlexWaygood reviewed May 19, 2023
View reviewed changes

JelleZijlstra mentioned this pull request May 19, 2023
gh-103921: Rename "type" header in argparse docs #104654
Merged

JelleZijlstra added a commit that referenced this pull request May 19, 2023
gh-103921: Rename "type" header in argparse docs (#104654)
ab8f546
This allows :keyword:`type` to link to docs for the new `type` statement (being written in gh-104642) instead of to this header in the argparse docs.

Merge branch 'main' into pep695docs
9d6e0c0

AlexWaygood reviewed May 19, 2023
View reviewed changes

Comment threadDoc/library/ast.rst Outdated

JelleZijlstra mentioned this pull request May 19, 2023
PEP 695: Rename typeparams to type_params in AST #104656
Closed

JelleZijlstra added 3 commits May 19, 2023 21:05

Expand typing.rst
e955a45

Finish the type statement
d7f2b55

What's New
53c4916

More comments
0cfeb92

AlexWaygood reviewed May 26, 2023
View reviewed changes

Comment threadObjects/typevarobject.c Outdated
Comment threadObjects/typevarobject.c Outdated
Comment threadObjects/typevarobject.c Outdated
Comment threadObjects/typevarobject.c

JelleZijlstra added 2 commits May 26, 2023 09:17

Docstring fixes
f978766

tables
bba092d

carljm mentioned this pull request May 26, 2023
gh-104984: remove kwargs and starargs from Call & ClassDef #104986
Merged

AlexWaygood approved these changes May 26, 2023
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels May 26, 2023

JelleZijlstraand others added 3 commits May 26, 2023 09:48

more fixes
57ddbef

Merge remote-tracking branch 'upstream/main' into pep695docs
67acd98

Merge branch 'main' into pep695docs
988fc7c

JelleZijlstra merged commit 060277d into python:mainMay 26, 2023

bedevere-bot removed the awaiting merge label May 26, 2023

JelleZijlstra deleted the pep695docs branch May 26, 2023 17:48

bedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023

JelleZijlstra added a commit that referenced this pull request May 26, 2023
[3.12]gh-103921: Document PEP 695 (GH-104642) (#104989)
dcee0aa
(cherry picked from commit 060277d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

JelleZijlstra mentioned this pull request May 27, 2023
[3.11] gh-103921: Improve typing documentation (GH-104642) #105007
Merged

AlexWaygood reviewed May 27, 2023
View reviewed changes

JelleZijlstra added a commit that referenced this pull request May 27, 2023
[3.11]gh-103921: Improve typing documentation (GH-104642) (#105007)
d34e58a
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed

AlexWaygood mentioned this pull request Aug 31, 2024
gh-123523: Rework typing documentation for generators and coroutines, and link to it from collections.abc docs #123544
Merged

AA-Turner mentioned this pull request Oct 19, 2024
Use the latest Sphinx version #125722
Closed

picnixz mentioned this pull request May 7, 2026
Clarify what memoryview is generic in #149488
Closed

Uh oh!

Uh oh!

Conversation

JelleZijlstra commented May 19, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hugovk commented May 19, 2023

Uh oh!

AlexWaygood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

AlexWaygoodMay 26, 2023

Choose a reason for hiding this comment

Uh oh!

JelleZijlstraMay 26, 2023

Choose a reason for hiding this comment

Uh oh!

AlexWaygoodMay 26, 2023

Choose a reason for hiding this comment

Uh oh!

miss-islington commented May 26, 2023

Uh oh!

bedevere-bot commented May 26, 2023

Uh oh!

carljm commented May 26, 2023

Uh oh!

AlexWaygood commented May 26, 2023

Uh oh!

bedevere-bot commented May 27, 2023

Uh oh!

AlexWaygoodMay 27, 2023

Choose a reason for hiding this comment

Uh oh!

AlexWaygoodMay 27, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

JelleZijlstra commented May 19, 2023•
edited
Loading

AlexWaygood left a comment •
edited
Loading