Skip to content

GH-104668: Don't call PyOS_* hooks in subinterpreters - #104674

Merged
brandtbucher merged 6 commits into
python:mainfrom
brandtbucher:global-hooks
May 22, 2023
Merged

GH-104668: Don't call PyOS_* hooks in subinterpreters#104674
brandtbucher merged 6 commits into
python:mainfrom
brandtbucher:global-hooks

Conversation

@brandtbucher

@brandtbucherbrandtbucher commented May 19, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

PyOS_InputHook and PyOS_ReadlineFunctionPointer are now only called in the main interpreter.

📚 Documentation preview 📚: https://cpython-previews--104674.org.readthedocs.build/

@brandtbucherbrandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-tkinter topic-subinterpreters topic-C-API labels May 19, 2023
@brandtbucherbrandtbucher self-assigned this May 19, 2023
@bedevere-botbedevere-bot mentioned this pull request May 19, 2023
Closed
@erlend-aasland

erlend-aasland commented May 20, 2023

Copy link
Copy Markdown
Contributor

We should advertise this in What's New as well.

ericsnowcurrently
ericsnowcurrently approved these changes May 22, 2023
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandtbucher
brandtbucher enabled auto-merge (squash) May 22, 2023 19:25
@brandtbucher
brandtbucher merged commit 357bed0 into python:mainMay 22, 2023
@arhadthedev

arhadthedev commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Should we backport it to 3.12?

Edit: I noticed that the label isn't added yet.

@JelleZijlstra

JelleZijlstra commented May 22, 2023

Copy link
Copy Markdown
Member

@brandtbucher this didn't actually end up in the 3.12 branch. Should we backport it, or is it a new feature that should only go into 3.13?

@brandtbucherbrandtbucher added the needs backport to 3.12 only security fixes label May 22, 2023
@miss-islington

miss-islington commented May 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2023
@brandtbucher@miss-islington
pythonGH-104668: Don't call PyOS_* hooks in subinterpreters (pythonGH…
ef66708
…-104674)
(cherry picked from commit 357bed0)
Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot

bedevere-bot commented May 22, 2023

Copy link
Copy Markdown

GH-104760 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 22, 2023
@brandtbucher

brandtbucher commented May 22, 2023

Copy link
Copy Markdown
MemberAuthor

I was waiting for the label. 🙂

brandtbucher added a commit that referenced this pull request May 23, 2023
@miss-islington@brandtbucher
[3.12]GH-104668: Don't call PyOS_* hooks in subinterpreters (GH-104760)
905d419
GH-104668: Don't call PyOS_* hooks in subinterpreters (GH-104674)
(cherry picked from commit 357bed0)
Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner
@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees

@brandtbucherbrandtbucher

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-C-APItopic-subinterpreterstopic-tkintertype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@brandtbucher@erlend-aasland@arhadthedev@JelleZijlstra@miss-islington@bedevere-bot@ericsnowcurrently