Skip to content

gh-104683: Modernise Tools/clinic/ using pyupgrade - #104684

Merged
erlend-aasland merged 7 commits into
python:mainfrom
AlexWaygood:clinic-pyupgrade
May 20, 2023
Merged

gh-104683: Modernise Tools/clinic/ using pyupgrade#104684
erlend-aasland merged 7 commits into
python:mainfrom
AlexWaygood:clinic-pyupgrade

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented May 20, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This PR was produced by running pyupgrade Tools/clinic/clinic.py Tools/clinic/cpp.py --py310-plus. Most of the changes are to use f-strings rather than older string formatting techniques.

@bedevere-botbedevere-bot mentioned this pull request May 20, 2023
Closed
7 tasks
erlend-aasland
erlend-aasland reviewed May 20, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
AlexWaygoodand others added 3 commits May 20, 2023 18:58
erlend-aasland
erlend-aasland reviewed May 20, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
@AlexWaygood@erlend-aasland
Apply suggestions from code review
ee83e29
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
erlend-aasland reviewed May 20, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py
AlexWaygood
AlexWaygood commented May 20, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 20, 2023 19:57
erlend-aasland
erlend-aasland approved these changes May 20, 2023
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slowly, AC is becoming more maintainable. I like it. Thanks!

@erlend-aasland
erlend-aasland merged commit 19dd5aa into python:mainMay 20, 2023
@AlexWaygood
AlexWaygood deleted the clinic-pyupgrade branch May 20, 2023 20:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood@erlend-aasland@bedevere-bot