Skip to content

gh-104050: Add basic type hints to Argument Clinic clinic class - #104705

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:typed-clinic/clinic
May 21, 2023
Merged

gh-104050: Add basic type hints to Argument Clinic clinic class#104705
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:typed-clinic/clinic

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented May 20, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request May 20, 2023
Closed
AlexWaygood
AlexWaygood reviewed May 21, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some readability nits, and a few places where (if mypy doesn't complain about it), you could possibly make the annotations more precise (but those can all wait for now, if necessary)

Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py
Comment threadTools/clinic/clinic.py
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
AlexWaygood
AlexWaygood approved these changes May 21, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erlend-aasland

erlend-aasland commented May 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks!

Likewise! I'll look thrice before opening my next PRs, so you (hopefully) won't have to pick on basic stuff again :)

@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 21, 2023 20:28
@AlexWaygood

AlexWaygood commented May 21, 2023

Copy link
Copy Markdown
Member

Thanks!

Likewise! I'll look thrice before opening my next PRs, so you (hopefully) won't have to pick on basic stuff again :)

Hey, typing is hard, no sweat! I still make mistakes all the time :)

@erlend-aasland
erlend-aasland merged commit bf6dd8f into python:mainMay 21, 2023
@erlend-aasland
erlend-aasland deleted the typed-clinic/clinic branch May 21, 2023 20:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland@AlexWaygood@bedevere-bot