Skip to content

gh-104629: Build _testclinic extension module on Windows - #104723

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/windows-build
Jul 28, 2023
Merged

gh-104629: Build _testclinic extension module on Windows#104723
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/windows-build

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented May 21, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland
erlend-aasland requested a review from a team as a code ownerMay 21, 2023 16:42
@erlend-aasland
erlend-aasland requested review from zooba and zwareMay 21, 2023 16:42
@bedevere-botbedevere-bot mentioned this pull request May 21, 2023
Closed
@erlend-aaslanderlend-aasland added the needs backport to 3.11 only security fixes label May 21, 2023
@erlend-aasland

erlend-aasland commented May 21, 2023

Copy link
Copy Markdown
ContributorAuthor

DISCLAIMER: I don't have a Windows dev environment set up; I don't know anything about Visual Code (Visual Studio?). I have no idea if this works.

FYI, I used random GUID's.

@AlexWaygood

AlexWaygood commented May 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

I know nothing about the build system, but I can confirm that this builds fine on my Windows machine (building from the command line), and python -m test test_clinic -v still passes. The number of skipped tests goes from 51 to 0 :)

@erlend-aasland

erlend-aasland commented May 21, 2023

Copy link
Copy Markdown
ContributorAuthor

I know nothing about the build system, but I can confirm that this builds fine on my Windows machine (building from the command line), and python -m test test_clinic -v still passes. The number of skipped tests goes from 51 to 0 :)

Good to know! Thanks 😃

zooba
zooba reviewed May 22, 2023
View reviewed changes
Comment threadPCbuild/pcbuild.sln Outdated
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "_testcapi", "_testcapi.vcxproj", "{6901D91C-6E48-4BB7-9FEC-700C8131DF1D}"
EndProject
Project("{A840DDFB-ED50-484B-B527-B32E7CF90FD5}") = "_testclinic", "_testclinic.vcxproj", "{A840DDFB-ED50-484B-B527-B32E7CF90FD5}"

@zoobazoobaMay 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first guid should match the rest - it's the kind of the project, not the specific identifier.

@erlend-aaslanderlend-aaslandMay 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll update the PR.

@erlend-aaslanderlend-aaslandJun 2, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 355f339 look?

@erlend-aaslanderlend-aaslandJun 2, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 355f339 look?

Let me try again: how does 355f339ande9aa5a3 look?

Comment threadPCbuild/pcbuild.proj
@zwarezware added the needs backport to 3.12 only security fixes label May 30, 2023
@erlend-aasland

erlend-aasland commented Jul 27, 2023

Copy link
Copy Markdown
ContributorAuthor

@zooba or @zware: I totally forgot about this PR. With the current relatively high volume of clinic changes going on, I think it is important that we land this. Could one of you check if my last changes are ok?

zware
zware approved these changes Jul 28, 2023
View reviewed changes

@zwarezware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, and worked when I tried it. If there's anything we've missed, it can be cleaned up later :)

@erlend-aasland
erlend-aasland merged commit 3a1d819 into python:mainJul 28, 2023
@miss-islington

miss-islington commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3a1d819ebc36189e086198212822c9b29384f242 3.11

@bedevere-bot

bedevere-bot commented Jul 28, 2023

Copy link
Copy Markdown

GH-107393 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 28, 2023
@erlend-aasland
erlend-aasland deleted the clinic/windows-build branch July 28, 2023 16:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2023
@erlend-aasland@miss-islington
pythongh-104629: Build _testclinic extension module on Windows (pytho…
55a45d6
…nGH-104723)
(cherry picked from commit 3a1d819)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 28, 2023
@miss-islington@erlend-aasland
[3.12]gh-104629: Build _testclinic extension module on Windows (GH-1…
b4355de
…04723) (#107393)
(cherry picked from commit 3a1d819)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@zwarezware removed the needs backport to 3.11 only security fixes label Jul 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarezwarezware approved these changes
@zoobazoobaAwaiting requested review from zooba

Assignees

@erlend-aaslanderlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@AlexWaygood@miss-islington@bedevere-bot@zooba@zware