Skip to content

gh-104683: clinic.py: Improve coverage for the parse_converter method - #104729

Merged
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:argclinic-coverage
May 21, 2023
Merged

gh-104683: clinic.py: Improve coverage for the parse_converter method#104729
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:argclinic-coverage

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented May 21, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request May 21, 2023
Closed
7 tasks
@bedevere-botbedevere-bot added the tests Tests in the Lib/test dir label May 21, 2023
erlend-aasland
erlend-aasland approved these changes May 21, 2023
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood
AlexWaygood enabled auto-merge (squash) May 21, 2023 22:41
@AlexWaygood

AlexWaygood commented May 21, 2023

Copy link
Copy Markdown
MemberAuthor

I'll leave the decision to you as to whether to backport this!

@erlend-aaslanderlend-aasland added the needs backport to 3.11 only security fixes label May 21, 2023
@erlend-aasland

erlend-aasland commented May 21, 2023

Copy link
Copy Markdown
Contributor

I (almost) always backport tests :) We need good test coverage in all active releases.

@AlexWaygood

AlexWaygood commented May 21, 2023

Copy link
Copy Markdown
MemberAuthor

I (almost) always backport tests :) We need good test coverage in all active releases.

I do the same over at typing.py, but I know opinions differ!

@AlexWaygood
AlexWaygood merged commit 64d1b44 into python:mainMay 21, 2023
@miss-islington

miss-islington commented May 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 64d1b44a5459605af3e8572d4febfde021315633 3.11

@AlexWaygood
AlexWaygood deleted the argclinic-coverage branch May 21, 2023 23:02
@AlexWaygoodAlexWaygood mentioned this pull request May 21, 2023
Merged
@bedevere-bot

bedevere-bot commented May 21, 2023

Copy link
Copy Markdown

GH-104730 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 21, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request May 21, 2023
@AlexWaygood
pythongh-104683:clinic.py: Improve coverage for the `parse_convert…
b59fb65
…er` method (python#104729)
AlexWaygood added a commit that referenced this pull request May 21, 2023
@AlexWaygood
[3.11]gh-104683:clinic.py: Improve coverage for the `parse_conver…
d691de1
…ter` method (#104729) (#104730)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

@AlexWaygoodAlexWaygood

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexWaygood@erlend-aasland@miss-islington@bedevere-bot