Skip to content

gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes - #104752

Merged
corona10 merged 2 commits into
python:mainfrom
corona10:gh-101282-fix-macos-other
May 24, 2023
Merged

gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes#104752
corona10 merged 2 commits into
python:mainfrom
corona10:gh-101282-fix-macos-other

Conversation

@corona10

@corona10corona10 commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Without this revert on macOS:

checking for --enable-bolt... no
checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... ./configure: line 8401: -reorder-blocks=ext-tsp: command not found

With this revert on macOS:

checking BOLT_INSTRUMENT_FLAGS...
checking BOLT_APPLY_FLAGS... -update-debug-sections -reorder-blocks=ext-tsp -reorder-functions=hfsort+ -split-functions -icf=1 -inline-all -split-eh -reorder-functions-use-hot-size -peepholes=none -jump-tables=aggressive -inline-ap -indirect-call-promotion=all -dyno-stats -use-gnu-stack -frame-opt=hot

@corona10
corona10 requested a review from ned-deilyMay 22, 2023 16:02
@bedevere-botbedevere-bot mentioned this pull request May 22, 2023
Closed
4 tasks
@corona10

corona10 commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

cc @indygreg Not decided yet which PR will be merged

@corona10corona10 added the needs backport to 3.12 only security fixes label May 23, 2023
@erlend-aasland

erlend-aasland commented May 23, 2023

Copy link
Copy Markdown
Contributor

Dong-hee: I'll take a look tonight (CET).

@corona10corona10 mentioned this pull request May 23, 2023
Closed
erlend-aasland
erlend-aasland reviewed May 24, 2023
View reviewed changes
Comment threadconfigure.ac Outdated
erlend-aasland
erlend-aasland requested changes May 24, 2023
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/python/cpython/pull/104752/files#r1203531051

@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@erlend-aaslanderlend-aasland changed the title gh-101282: Fix M4 style for BOLT configurationgh-101282: Enclose BOLT_APPLY_FLAGS value in double quotesMay 24, 2023
@erlend-aaslanderlend-aasland mentioned this pull request May 24, 2023
Closed
@erlend-aasland

erlend-aasland commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks!

@corona10
corona10 merged commit c437851 into python:mainMay 24, 2023
@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 24, 2023

Copy link
Copy Markdown
Contributor

Sorry @corona10, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker c43785192c97698a0217a680b30baae22106ed3e 3.12

@miss-islingtonmiss-islington assigned corona10 and unassigned Yhg1sMay 24, 2023
corona10 added a commit to corona10/cpython that referenced this pull request May 24, 2023
@corona10
[3.12]pythongh-101282: Enclose BOLT_APPLY_FLAGS value in double quot…
36f5894
…es (pythongh-104752)
(cherry picked from commit c437851)
Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104853 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 24, 2023
@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

GH-104853 is a backport of this pull request to the 3.12 branch.

@erlend-aasland

erlend-aasland commented May 24, 2023

Copy link
Copy Markdown
Contributor

I forgot to ask the obvious question: did you verify that the warning disappeared?

corona10 added a commit that referenced this pull request May 24, 2023
@corona10
[3.12]gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes (gh… (
b151660
gh-104853)
[3.12] gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes (gh-104752)
(cherry picked from commit c437851)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@ned-deilyned-deilyAwaiting requested review from ned-deily

Assignees

@corona10corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10@erlend-aasland@bedevere-bot@miss-islington@Yhg1s