Skip to content

gh-104497: Make tkinter test pass with tk 8.7 - #104789

Merged
terryjreedy merged 2 commits into
python:mainfrom
terryjreedy:tkalpha
May 27, 2023
Merged

gh-104497: Make tkinter test pass with tk 8.7#104789
terryjreedy merged 2 commits into
python:mainfrom
terryjreedy:tkalpha

Conversation

@terryjreedy

@terryjreedyterryjreedy commented May 23, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

For test_widgets.MenuTest.test_configure_type, the options in the error message change to alphabetical order.

@terryjreedy
pythongh-104497: Make tkinter test pass with tk 8.7
ff8f707
For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
@terryjreedyterryjreedy added tests Tests in the Lib/test dir skip news DO-NOT-MERGE needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 23, 2023
@terryjreedyterryjreedy self-assigned this May 23, 2023
@bedevere-botbedevere-bot mentioned this pull request May 23, 2023
Closed
@terryjreedy

terryjreedy commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

@chrstphrchvz please verify that this passes on 8.7.

@serhiy-storchaka I presume a root.destroy call is needed rather than merely deleting the python binding. If another test in the file ever needs a fix for 8.7 or 9.0, etc., fetching tk_version could be moved to the top of the file, or I could do so now if you prefer.

@terryjreedy

terryjreedy commented May 24, 2023

Copy link
Copy Markdown
MemberAuthor

@chrstphrchvz Please verify that this run without error on 8.7.

@serhiy-storchaka If tk_ver were someday needed for another test, it could be moved to module level. I can do so now if you want.

I presume that explicit root.destroy is needed before exiting the function.

chrstphrchvz
chrstphrchvz reviewed May 24, 2023
View reviewed changes

@chrstphrchvzchrstphrchvz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the test passes on Tk 8.7 with this change.

Comment threadLib/test/test_tkinter/test_widgets.py Outdated
Comment threadLib/test/test_tkinter/test_widgets.py Outdated
serhiy-storchaka
serhiy-storchaka reviewed May 24, 2023
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use widget.info_patchlevel() in 3.11+, or test.test_tkinter.support.tcl_version or test.test_tkinter.support.get_tk_patchlevel() in older versions.

serhiy-storchaka
serhiy-storchaka reviewed May 24, 2023
View reviewed changes
Comment threadLib/test/test_tkinter/test_widgets.py Outdated
@terryjreedy@serhiy-storchaka
Update Lib/test/test_tkinter/test_widgets.py
ac16189
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@terryjreedy
terryjreedy enabled auto-merge (squash) May 27, 2023 19:03
@terryjreedy

terryjreedy commented May 27, 2023

Copy link
Copy Markdown
MemberAuthor

This PR was written specifically as it is because this was the only known test failure when written. #104855 and #104856 report more is test_widget and widget_test. I will later list the alternatives I see in the first of those issues.

@terryjreedy
terryjreedy merged commit 897e716 into python:mainMay 27, 2023
@miss-islington

miss-islington commented May 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105028 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@terryjreedy@serhiy-storchaka@miss-islington
pythongh-104497: Make tkinter test pass with tk 8.7 (pythonGH-104789)
3fdfdab
* pythongh-104497: Make tkinter test pass with tk 8.7
For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
* Update Lib/test/test_tkinter/test_widgets.py
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
---------
(cherry picked from commit 897e716)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 27, 2023
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105029 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 27, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2023
@terryjreedy@serhiy-storchaka@miss-islington
pythongh-104497: Make tkinter test pass with tk 8.7 (pythonGH-104789)
afe4b8d
* pythongh-104497: Make tkinter test pass with tk 8.7
For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
* Update Lib/test/test_tkinter/test_widgets.py
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
---------
(cherry picked from commit 897e716)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy added a commit that referenced this pull request May 27, 2023
@miss-islington@terryjreedy@serhiy-storchaka
[3.12]gh-104497: Make tkinter test pass with tk 8.7 (GH-104789) (#10…
5426ff1
…5028)
For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
---------
(cherry picked from commit 897e716)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy added a commit that referenced this pull request May 27, 2023
@miss-islington@terryjreedy@serhiy-storchaka
[3.11]gh-104497: Make tkinter test pass with tk 8.7 (GH-104789) (#10…
dcfa816
…5029)
For test_widgets.MenuTest.test_configure_type, the options
in the error message change to alphabetical order.
---------
(cherry picked from commit 897e716)
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@terryjreedy
terryjreedy deleted the tkalpha branch May 27, 2023 21:53
@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments
+1 more reviewer
@chrstphrchvzchrstphrchvzchrstphrchvz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@terryjreedyterryjreedy

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@terryjreedy@miss-islington@bedevere-bot@serhiy-storchaka@chrstphrchvz