Skip to content

gh-104773: PEP 594: Remove the chunk module - #104868

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_chunk
May 25, 2023
Merged

gh-104773: PEP 594: Remove the chunk module#104868
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_chunk

Conversation

@vstinner

@vstinnervstinner commented May 24, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot mentioned this pull request May 24, 2023
Closed
19 tasks
hugovk
hugovk requested changes May 24, 2023
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove Doc/library/chunk.rst from Doc/tools/.nitignore

@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
MemberAuthor

Let's also remove Doc/library/chunk.rst from Doc/tools/.nitignore

Oh, I missed that one: it's now removed.

@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented May 24, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@bedevere-bot
bedevere-bot requested a review from hugovkMay 24, 2023 15:16
hugovk
hugovk approved these changes May 24, 2023
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner
vstinner enabled auto-merge (squash) May 24, 2023 15:26
@vstinner

vstinner commented May 24, 2023

Copy link
Copy Markdown
MemberAuthor

Oh. test_aifc uses the chunk module. It should be removed before the chunk module can be removed:

test test_aifc crashed -- Traceback (most recent call last):
(...)
File "D:\a\cpython\cpython\Lib\aifc.py", line 260, in <module>
from chunk import Chunk
ModuleNotFoundError: No module named 'chunk'

@vstinner
vstinner marked this pull request as draft May 24, 2023 15:43
auto-merge was automatically disabled May 24, 2023 15:43

Pull request was converted to draft

@vstinnervstinner changed the title gh-104773: PEP 594: Remove the chunk moduleWIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk moduleMay 24, 2023
@vstinnervstinner mentioned this pull request May 25, 2023
Merged
@vstinnervstinner changed the title WIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk modulegh-104773: PEP 594: Remove the chunk moduleMay 25, 2023
@vstinner
vstinner marked this pull request as ready for review May 25, 2023 16:02
@vstinner

vstinner commented May 25, 2023

Copy link
Copy Markdown
MemberAuthor

PR rebased on main, now that the aifc module has been removed.

@vstinner
vstinner enabled auto-merge (squash) May 25, 2023 16:09
@vstinner
vstinner merged commit 77d7ec5 into python:mainMay 25, 2023
@vstinner
vstinner deleted the remove_chunk branch May 25, 2023 16:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@bedevere-bot@hugovk