Uh oh!
There was an error while loading. Please reload this page.
gh-104874: Document NewType.__supertype__ - #104875
Conversation
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks good. We also test for __qualname__ and __module__; should we document those as well?
cpython/Lib/test/test_typing.py
Lines 6658 to 6669 in c90a862
JelleZijlstra
commented
May 24, 2023
|
AlexWaygood
commented
May 24, 2023
I feel like it could be useful to be able to know the module the newtype was defined in, and it seems useful to mention the ways in which instances of |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
miss-islington
commented
May 24, 2023
Thanks @JelleZijlstra for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
(cherry picked from commit 41768a2) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
bedevere-bot
commented
May 24, 2023
GH-104906 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit 41768a2) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
bedevere-bot
commented
May 24, 2023
GH-104907 is a backport of this pull request to the 3.11 branch. |
Fixes#104874
NewType.__supertype__#104874📚 Documentation preview 📚: https://cpython-previews--104875.org.readthedocs.build/