Skip to content

gh-104773: PEP 594: Remove the nis module - #104897

Merged
vstinner merged 3 commits into
python:mainfrom
vstinner:remove_nis
May 24, 2023
Merged

gh-104773: PEP 594: Remove the nis module#104897
vstinner merged 3 commits into
python:mainfrom
vstinner:remove_nis

Conversation

@vstinner

@vstinnervstinner commented May 24, 2023

Copy link
Copy Markdown
Member

@hugovk

Copy link
Copy Markdown
Member

Some extra nismodule / libnsl bits to remove?

Tools/c-analyzer/cpython/ignored.tsv
285:Modules/nismodule.c - TIMEOUT -
286:Modules/nismodule.c - aliases -
Tools/c-analyzer/cpython/_parser.py
123:Modules/nismodule.c /usr/include/tirpc
Tools/c-analyzer/cpython/globals-to-fix.tsv
458:Modules/nismodule.c nisproc_maplist_2 res -
PC/pyconfig.h
679:#define HAVE_LIBNSL 1

@vstinner
vstinner requested a review from a team as a code ownerMay 24, 2023 21:31
@vstinner

Copy link
Copy Markdown
MemberAuthor

Some extra nismodule / libnsl bits to remove?

Well spotted: removed as well.

For now, I prefer to keep this code in configure.ac, since I don't know its purpose and I cannot test a change on Solaris:

$ git grep -B1 -A1 '\<nsl\>'
configure.ac-# Most SVR4 platforms (e.g. Solaris) need -lsocket and -lnsl.
configure.ac:AC_CHECK_LIB(nsl, t_open, [LIBS="-lnsl $LIBS"]) # SVR4
configure.ac-AC_CHECK_LIB(socket, socket, [LIBS="-lsocket $LIBS"], [], $LIBS) # SVR4 sockets

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@hugovk@bedevere-bot