Skip to content

gh-104924: Fix read()able in http.client log messages - #104926

Merged
corona10 merged 2 commits into
python:mainfrom
arhadthedev:http-read-able
May 26, 2023
Merged

gh-104924: Fix read()able in http.client log messages#104926
corona10 merged 2 commits into
python:mainfrom
arhadthedev:http-read-able

Conversation

@arhadthedev

@arhadthedevarhadthedev commented May 25, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@arhadthedevarhadthedev added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels May 25, 2023
@bedevere-botbedevere-bot mentioned this pull request May 25, 2023
Closed
gaogaotiantian
gaogaotiantian requested changes May 25, 2023
View reviewed changes

@gaogaotiantiangaogaotiantian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sendIng is an obvious typo. On line 1057, from some brief reading, it's not "sending" a readable, but "reading" from a readable(as indicated by the function name).

Comment threadLib/http/client.py Outdated
Comment threadLib/http/client.py Outdated
@arhadthedev@gaogaotiantian
sendIng -> reading
644722d
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@Eclips4Eclips4 mentioned this pull request May 25, 2023
Closed
@LyingDalai

LyingDalai commented May 25, 2023

Copy link
Copy Markdown

I have looked for any related typo with “Ing the read()”. I know PyCharm can make funny replacements but I still haven’t found where this would come from.

corona10
corona10 approved these changes May 26, 2023
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10
corona10 merged commit 6c81d75 into python:mainMay 26, 2023
@miss-islington

miss-islington commented May 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @arhadthedev for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@arhadthedev@miss-islington
pythongh-104924: Fixread()ableinhttp.clientlog messages (pyth…
8ec8ba9
…ongh-104926)
(cherry picked from commit 6c81d75)
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104970 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104971 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@arhadthedev@miss-islington
pythongh-104924: Fixread()ableinhttp.clientlog messages (pyth…
0906563
…ongh-104926)
(cherry picked from commit 6c81d75)
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@arhadthedev
arhadthedev deleted the http-read-able branch May 26, 2023 11:53
corona10 pushed a commit that referenced this pull request May 26, 2023
@miss-islington@arhadthedev
[3.11]gh-104924: Fixread()ableinhttp.clientlog messages (gh-…
f585ed1
…104926) (gh-104971)
gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)
(cherry picked from commit 6c81d75)
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
corona10 pushed a commit that referenced this pull request May 26, 2023
@miss-islington@arhadthedev
[3.12]gh-104924: Fixread()ableinhttp.clientlog messages (gh-…
83bdfa4
…104926) (gh-104970)
gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)
(cherry picked from commit 6c81d75)
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 approved these changes
@gaogaotiantiangaogaotiantiangaogaotiantian approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arhadthedev@LyingDalai@miss-islington@bedevere-bot@corona10@gaogaotiantian