Uh oh!
There was an error while loading. Please reload this page.
gh-104773: PEP 594: Remove the aifc module - #104927
Closed
fatelei wants to merge 1 commit into
Closed
Conversation
19 tasks
All commit authors signed the Contributor License Agreement. |
DBJim
reviewed
May 25, 2023
DBJim
left a comment
Contributor
There was a problem hiding this comment.
Looks like the cause of docs test failure
| +---------------------+---------------------+---------------------+---------------------+---------------------+ | ||
| | :mod:`aifc` | :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` | | ||
| | :mod:`!aifc` | :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` | |
Contributor
There was a problem hiding this comment.
Suggested change
| |:mod:`!aifc` | :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` | | |
| |:mod:`!aifc` | :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` | |
| @@ -1,6 +1,5 @@ | |||
| # Binary data types | |||
| *.aif binary | |||
| *.aifc binary | |||
Member
There was a problem hiding this comment.
I don't think that this change is correct. The Lib/test/test_email/data/sndhdr.aifc file should still be treated as binary by Git.
vstinner
commented
May 25, 2023
Member
Thanks for your contribution! I merged my PR #104933 instead (more complete). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove aifc module
issue #104773
📚 Documentation preview 📚: https://cpython-previews--104927.org.readthedocs.build/