Skip to content

gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except* implementation in the unstable API - #105072

Merged
iritkatriel merged 4 commits into
python:mainfrom
iritkatriel:PyUnstable_Exc_PrepReraiseStar
May 30, 2023
Merged

gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except* implementation in the unstable API#105072
iritkatriel merged 4 commits into
python:mainfrom
iritkatriel:PyUnstable_Exc_PrepReraiseStar

Conversation

@iritkatriel

@iritkatrieliritkatriel commented May 29, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

I did not rename the internal function, but rather added an API function that calls it. This is because the internal function can make more assumptions about the input than an API function (so the API function raises exceptions on things that the internal function just asserts).

Fixes#105071.

CC @da-woods .

📚 Documentation preview 📚: https://cpython-previews--105072.org.readthedocs.build/

@iritkatriel
iritkatriel requested a review from encukouMay 29, 2023 20:14
@bedevere-botbedevere-bot mentioned this pull request May 29, 2023
Closed
@iritkatrieliritkatriel mentioned this pull request May 29, 2023
Open
erlend-aasland
erlend-aasland reviewed May 30, 2023
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc formatting nits. Otherwise: lgtm, as far as I can see.

Comment threadDoc/c-api/exceptions.rst Outdated
Comment threadDoc/c-api/exceptions.rst Outdated
Comment threadDoc/c-api/exceptions.rst Outdated
iritkatriel
iritkatriel commented May 30, 2023
View reviewed changes
Comment threadObjects/exceptions.c Outdated
iritkatriel
iritkatriel commented May 30, 2023
View reviewed changes
Comment threadObjects/exceptions.c Outdated
iritkatrieland others added 2 commits May 30, 2023 11:12
@iritkatriel@erlend-aasland
Apply suggestions from code review
b0a7b99
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@blurb-it
📜🤖 Added by blurb_it.
784b102
encukou
encukou approved these changes May 30, 2023
View reviewed changes

@encukouencukou left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@iritkatrieliritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 30, 2023
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 784b102 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 30, 2023
@iritkatrieliritkatriel added needs backport to 3.12 only security fixes topic-C-API interpreter-core (Objects, Python, Grammar, and Parser dirs) and removed topic-C-API labels May 30, 2023
@iritkatriel
iritkatriel merged commit b7aadb4 into python:mainMay 30, 2023
@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 30, 2023

Copy link
Copy Markdown
Contributor

Sorry @iritkatriel, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker b7aadb4583b040ddc8564896b91f4e5e571c82d6 3.12

iritkatriel added a commit to iritkatriel/cpython that referenced this pull request May 30, 2023
@iritkatriel
[3.12]pythongh-105071: add PyUnstable_Exc_PrepReraiseStar to expose …
28e968b
…except* implementation in the unstable API (pythonGH-105072)
(cherry picked from commit b7aadb4)
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatrieliritkatriel mentioned this pull request May 30, 2023
Merged
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105095 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label May 30, 2023
@bedevere-bot

bedevere-bot commented May 30, 2023

Copy link
Copy Markdown

GH-105095 is a backport of this pull request to the 3.12 branch.

iritkatriel added a commit that referenced this pull request May 30, 2023
@iritkatriel
[3.12]gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except…
b45df73
…* implementation in the unstable API (GH-105072) (#105095)
(cherry picked from commit b7aadb4)
@hugovkhugovk mentioned this pull request May 30, 2023
Merged
@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
@iritkatriel
iritkatriel deleted the PyUnstable_Exc_PrepReraiseStar branch July 25, 2023 18:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments
@encukouencukouencukou approved these changes

Assignees

@iritkatrieliritkatriel

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add PyUnstable_Exc_PrepReraiseStar

5 participants

@iritkatriel@bedevere-bot@miss-islington@encukou@erlend-aasland