Uh oh!
There was an error while loading. Please reload this page.
gh-57531 add BufferedReader.read() return value check for non-blocking stream mode - #105224
gh-57531 add BufferedReader.read() return value check for non-blocking stream mode#105224z764969689 wants to merge 22 commits into
Conversation
serhiy-storchaka
commented
Jan 17, 2024
Please resolve conflicts and add tests. Also capitalize the first letter of a sentence in a NEWS entry. |
@serhiy-storchaka Conflicts resolved & NEWS entry edited. I'm wondering if I need to open another PR for the tests or just add them in this one. |
serhiy-storchaka
commented
Jan 19, 2024
It is better to add new tests in the same PR. It makes easier to check that they fail without this change and pass with it. |
z764969689
commented
Jan 19, 2024
I've added a simple test case and I found that the test case would fail the C implementation. Since I'm unfamiliar with the C code, might need some help from others to modify the C code. |
serhiy-storchaka
commented
Jan 29, 2024
It is more complex issue than covered in this PR. If change the behavior of text file read() for non-blocking buffered readers, the same change should be done for non-blocking raw files. If change the behavior for "read-until-end", the same change should be done for partial read. And of course the behavior of both C and Python implementation should be consistent. Thank you for reviving this issue, I will look what can I do with this. |
gh-57531 add
BufferedReader.read()return value check for non-blocking stream mode, simply opt theTextIOWrappererror raising.