Skip to content

gh-105237: Allow calling issubclass(X, typing.Protocol) again - #105239

Merged
JelleZijlstra merged 6 commits into
python:mainfrom
AlexWaygood:protocol-subclass-regression
Jun 5, 2023
Merged

gh-105237: Allow calling issubclass(X, typing.Protocol) again#105239
JelleZijlstra merged 6 commits into
python:mainfrom
AlexWaygood:protocol-subclass-regression

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Jun 2, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@AlexWaygoodAlexWaygood added type-bug An unexpected behavior, bug, or error skip news stdlib Standard Library Python modules in the Lib/ directory topic-typing needs backport to 3.12 only security fixes labels Jun 2, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 2, 2023
Closed
AlexWaygood
AlexWaygood commented Jun 2, 2023
View reviewed changes
Comment threadLib/test/test_typing.py Outdated
@AlexWaygoodAlexWaygood changed the title gh-105237: Allow calling issubclass(X, Protocol) againgh-105237: Allow calling issubclass(X, typing.Protocol) againJun 2, 2023
JelleZijlstra
JelleZijlstra reviewed Jun 2, 2023
View reviewed changes
Comment threadLib/typing.py
AlexWaygood
AlexWaygood commented Jun 2, 2023
View reviewed changes
Comment threadLib/typing.py
@AlexWaygood

AlexWaygood commented Jun 4, 2023

Copy link
Copy Markdown
MemberAuthor

I've run the third-party tests we have at typing_extensions on a version of this PR. In combination with #105281, this causes no regressions.

@AlexWaygoodAlexWaygood mentioned this pull request Jun 4, 2023
Merged
@JelleZijlstra
JelleZijlstra merged commit cdfb201 into python:mainJun 5, 2023
@miss-islington

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Sorry @AlexWaygood and @JelleZijlstra, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker cdfb201bfa35b7c50de5099c6d9078c806851d98 3.12

@JelleZijlstraJelleZijlstra added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 5, 2023
@miss-islington

miss-islington commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2023
@AlexWaygood@miss-islington
pythongh-105237: Allow callingissubclass(X, typing.Protocol)again (…
f45b5d7
…pythonGH-105239)
(cherry picked from commit cdfb201)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot

bedevere-bot commented Jun 5, 2023

Copy link
Copy Markdown

GH-105316 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 5, 2023
@AlexWaygood
AlexWaygood deleted the protocol-subclass-regression branch June 5, 2023 13:37
AlexWaygood added a commit that referenced this pull request Jun 5, 2023
@miss-islington@AlexWaygood
[3.12]gh-105237: Allow callingissubclass(X, typing.Protocol)again (
5175026
GH-105239) (#105316)
gh-105237: Allow calling `issubclass(X, typing.Protocol)` again (GH-105239)
(cherry picked from commit cdfb201)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aaslanderlend-aasland mentioned this pull request Jun 6, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

@JelleZijlstraJelleZijlstra

Labels

stdlibStandard Library Python modules in the Lib/ directorytopic-typingtype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexWaygood@miss-islington@bedevere-bot@JelleZijlstra