Uh oh!
There was an error while loading. Please reload this page.
gh-105310: add decorator to skip rerunning tests - #105311
Conversation
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Jun 5, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sunmy2019
commented
Jun 5, 2023
I have made the requested changes; please review again I think we need news for this one, right? |
bedevere-bot
commented
Jun 5, 2023
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
erlend-aasland
commented
Jun 5, 2023
Well, test changes rarely get their own NEWS items. Personally, I would not bother with it. Related: also note that a lot of the |
sunmy2019
commented
Jun 20, 2023
Closed. See #104796 (comment) |
Personally, I am not satisfied with the test case added in
test_support.py, but I can not figure out something better.