Skip to content

gh-104269: Document glob.glob duplicates when using multiple ** patterns - #105406

Merged
barneygale merged 11 commits into
python:mainfrom
tomasr8:glob-duplicates
Apr 11, 2024
Merged

gh-104269: Document glob.glob duplicates when using multiple ** patterns#105406
barneygale merged 11 commits into
python:mainfrom
tomasr8:glob-duplicates

Conversation

@tomasr8

@tomasr8tomasr8 commented Jun 6, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot added awaiting review docs Documentation in the Doc dir labels Jun 6, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 6, 2023
Closed
evildmp
evildmp reviewed Jul 22, 2023
View reviewed changes
Comment threadDoc/library/glob.rst
Comment threadDoc/library/glob.rst
Comment threadMisc/NEWS.d/next/Documentation/2023-06-06-21-18-14.gh-issue-104269.uP1hVC.rst Outdated
@tomasr8

tomasr8 commented Jul 23, 2023

Copy link
Copy Markdown
MemberAuthor

Just adding a comment here as well - The style guide says to use italics for parameters instead of literals

@ghost

ghost commented Jul 23, 2023•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@tomasr8

tomasr8 commented Jul 23, 2023

Copy link
Copy Markdown
MemberAuthor

Hi @barneygale! Would you mind having a look at this? Thank you :)

evildmp
evildmp suggested changes Jul 23, 2023
View reviewed changes
Comment threadDoc/library/glob.rst
@barneygale
barneygale self-requested a review July 24, 2023 16:30
barneygale
barneygale requested changes Jan 20, 2024
View reviewed changes

@barneygalebarneygale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late feedback.

Comment threadDoc/library/glob.rst Outdated
Comment threadDoc/library/glob.rst Outdated
Comment threadMisc/NEWS.d/next/Documentation/2023-06-06-21-18-14.gh-issue-104269.uP1hVC.rst Outdated
@bedevere-app

bedevere-appBot commented Jan 20, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tomasr8

tomasr8 commented Jan 20, 2024

Copy link
Copy Markdown
MemberAuthor

Sorry for the very late feedback.

Better late than never ;)

tomasr8and others added 2 commits January 22, 2024 09:59
@tomasr8@barneygale
Improve wording
fe34443
Co-authored-by: Barney Gale <barney.gale@gmail.com>
@tomasr8
Remove news entry
75d8eaf
@tomasr8

tomasr8 commented Jan 22, 2024

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again

@tomasr8

tomasr8 commented Feb 6, 2024

Copy link
Copy Markdown
MemberAuthor

Hmm seems like bedevere did not pick up that comment :/ @barneygale

@hugovkhugovk removed the needs backport to 3.11 only security fixes label Apr 11, 2024
@hugovk
hugovk requested a review from barneygaleApril 11, 2024 14:09
@barneygale

barneygale commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

My apologies once again for the long wait. Thank you for the patch, this looks good.

@barneygale
barneygale enabled auto-merge (squash) April 11, 2024 15:04
@barneygale
barneygale merged commit c06be6b into python:mainApr 11, 2024
@miss-islington-app

miss-islington-appBot commented Apr 11, 2024

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @barneygale for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2024
@tomasr8@miss-islington
pythongh-104269: Documentglob.globduplicates when using multiple …
364cd66
…`**` patterns (pythonGH-105406)
(cherry picked from commit c06be6b)
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-app

bedevere-appBot commented Apr 11, 2024

Copy link
Copy Markdown

GH-117757 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Apr 11, 2024
@tomasr8
tomasr8 deleted the glob-duplicates branch April 11, 2024 15:20
barneygale pushed a commit that referenced this pull request Apr 11, 2024
@miss-islington@tomasr8
[3.12]gh-104269: Documentglob.globduplicates when using multiple…
84fb531
… `**` patterns (GH-105406) (#117757)
gh-104269: Document `glob.glob` duplicates when using multiple `**` patterns (GH-105406)
(cherry picked from commit c06be6b)
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@tomasr8@diegorusso
pythongh-104269: Documentglob.globduplicates when using multiple …
4c350d2
…`**` patterns (python#105406)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygalebarneygalebarneygale approved these changes
+1 more reviewer
@evildmpevildmpevildmp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomasr8@barneygale@evildmp@hugovk@bedevere-bot