Skip to content

gh-103171: Forward-port new tests for runtime-checkable protocols decorated with @final - #105473

Merged
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:Finalprotocol
Jun 7, 2023
Merged

gh-103171: Forward-port new tests for runtime-checkable protocols decorated with @final#105473
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:Finalprotocol

Conversation

@AlexWaygood

@AlexWaygoodAlexWaygood commented Jun 7, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@AlexWaygood
pythongh-103171: Forward-port new tests for runtime-checkable protoco…
e96c2e8
…ls decorated with `@final`
Forward-port of the tests that were added to the 3.11 branch in python#105445
@bedevere-botbedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 7, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 7, 2023
Closed
@AlexWaygoodAlexWaygood added the needs backport to 3.12 only security fixes label Jun 7, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) June 7, 2023 22:19
@AlexWaygoodAlexWaygood changed the title gh-103171: Forward-port new tests for runtime-checkable protocols dec orated with @finalgh-103171: Forward-port new tests for runtime-checkable protocols decorated with @finalJun 7, 2023
@AlexWaygood
AlexWaygood merged commit f5df347 into python:mainJun 7, 2023
@miss-islington

miss-islington commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105474 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood@miss-islington
pythongh-103171: Forward-port new tests for runtime-checkable protoco…
0e124fc
…ls dec orated with `@final` (pythonGH-105473)
Forward-port of the tests that were added to the 3.11 branch in pythonGH-105445
(cherry picked from commit f5df347)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood
AlexWaygood deleted the Finalprotocol branch June 7, 2023 22:26
@bedevere-bot

bedevere-bot commented Jun 7, 2023

Copy link
Copy Markdown

GH-105474 is a backport of this pull request to the 3.12 branch.

AlexWaygood added a commit that referenced this pull request Jun 7, 2023
@miss-islington@AlexWaygood
[3.12]gh-103171: Forward-port new tests for runtime-checkable protoc…
4b2263e
…ols decorated with `@final` (GH-105473) (#105474)
Forward-port of the tests that were added to the 3.11 branch in GH-105445
(cherry picked from commit f5df347)
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@gvanrossumgvanrossumAwaiting requested review from gvanrossum
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dirtopic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexWaygood@miss-islington@bedevere-bot@JelleZijlstra