Skip to content

gh-105486: Change the repr of ParamSpec list of args in GenericAlias - #105488

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
sobolevn:issue-105487
Jul 1, 2023
Merged

gh-105486: Change the repr of ParamSpec list of args in GenericAlias#105488
JelleZijlstra merged 4 commits into
python:mainfrom
sobolevn:issue-105487

Conversation

@sobolevn

@sobolevnsobolevn commented Jun 8, 2023•
edited by AlexWaygood
Loading

Copy link
Copy Markdown
Member

Now it looks like this:

>>> type A[X, **Y] =None>>>A[int, [str]]
A[int, [str]]

@bedevere-botbedevere-bot mentioned this pull request Jun 8, 2023
Closed
@AlexWaygoodAlexWaygood added the needs backport to 3.12 only security fixes label Jun 8, 2023
JelleZijlstra
JelleZijlstra reviewed Jun 8, 2023
View reviewed changes

@JelleZijlstraJelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadLib/test/test_type_aliases.py
Comment threadObjects/genericaliasobject.c Outdated
@sobolevn

sobolevn commented Jun 27, 2023

Copy link
Copy Markdown
MemberAuthor

Is there anything left?

@JelleZijlstra

JelleZijlstra commented Jun 30, 2023

Copy link
Copy Markdown
Member

@AlexWaygood you added the 3.12 backport label, but this feels like a feature change that should only go into main. What do you think?

Also, this PR is linked to issue #105487, but I don't see how it is related. I think this is a good change and we should merge it, but was there some other issue this should be linked to?

@JelleZijlstra

JelleZijlstra commented Jun 30, 2023

Copy link
Copy Markdown
Member

Ah it should be #105486, I'll update the PR.

@JelleZijlstraJelleZijlstra changed the title gh-105487: Change the repr of ParamSpec list of args in GenericAliasgh-105486: Change the repr of ParamSpec list of args in GenericAliasJun 30, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 8, 2023
Closed
@AlexWaygood

AlexWaygood commented Jun 30, 2023

Copy link
Copy Markdown
Member

@AlexWaygood you added the 3.12 backport label, but this feels like a feature change that should only go into main. What do you think?

Hmm, I view the current repr as pretty inconsistent — a latent bug that was exposed by the PEP-695 implementation. So I would favour backporting here. Given that 3.12 has yet to be released, I also think it will be less disruptive to change the repr now rather than have the repr change between 3.12 and 3.13, which could break people's doctests etc.

@JelleZijlstra

JelleZijlstra commented Jun 30, 2023

Copy link
Copy Markdown
Member

That's fair. I suppose you could technically run into this in 3.11, but PEP 695 makes it a lot easier. I'm fine with backporting.

@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) June 30, 2023 23:43
@JelleZijlstra
JelleZijlstra merged commit eb7d6e7 into python:mainJul 1, 2023
@miss-islington

miss-islington commented Jul 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2023
@sobolevn@miss-islington
pythongh-105486: Change thereprofParamSpeclist of args in `Ge…
9d46011
…nericAlias` (pythonGH-105488)
(cherry picked from commit eb7d6e7)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Jul 1, 2023

Copy link
Copy Markdown

GH-106297 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 1, 2023
JelleZijlstra pushed a commit that referenced this pull request Jul 1, 2023
@miss-islington@sobolevn
[3.12]gh-105486: Change thereprofParamSpeclist of args in `G…
c4298d5
…enericAlias` (GH-105488) (#106297)
gh-105486: Change the `repr` of `ParamSpec` list of args in `GenericAlias` (GH-105488)
(cherry picked from commit eb7d6e7)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
manosriram pushed a commit to manosriram/cpython that referenced this pull request Jul 1, 2023
@sobolevn@manosriram
pythongh-105486: Change thereprofParamSpeclist of args in `Ge…
a866b07
…nericAlias` (python#105488)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@JelleZijlstra@AlexWaygood@miss-islington@bedevere-bot