Uh oh!
There was an error while loading. Please reload this page.
gh-100227: Lock Around Adding Global Audit Hooks - #105515
Conversation
zooba
commented
Jun 8, 2023
I'd be just as happy with documenting that you need to self-synchronize when using this function. It should only be being called by embedders anyway. But this change looks okay. I'm not as familiar with our usual locking pattern though, so I'm trusting you're following that. |
ericsnowcurrently
commented
Jun 8, 2023
FWIW, we didn't have one before per-interpreter GIL. I've tried to be consistent, though, as I've been inventing the pattern. 😄 |
miss-islington
commented
Jun 8, 2023
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
commented
Jun 8, 2023
Sorry, @ericsnowcurrently, I could not cleanly backport this to |
miss-islington
commented
Jun 8, 2023
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
commented
Jun 8, 2023
Sorry @ericsnowcurrently, I had trouble checking out the |
miss-islington
commented
Jun 8, 2023
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
commented
Jun 8, 2023
Sorry @ericsnowcurrently, I had trouble checking out the |
miss-islington
commented
Jun 8, 2023
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
commented
Jun 8, 2023
Sorry @ericsnowcurrently, I had trouble checking out the |
The risk of a race with this state is relatively low, but we play it safe anyway.
bedevere-bot
commented
Jun 8, 2023
GH-105525 is a backport of this pull request to the 3.12 branch. |
The risk of a race with this state is relatively low, but we play it safe anyway.