Skip to content

gh-105375: Improve errnomodule error handling - #105590

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:improve-errno-error-handling
Jun 9, 2023
Merged

gh-105375: Improve errnomodule error handling#105590
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:improve-errno-error-handling

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 9, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Bail immediately if an exception is set, to prevent exceptions from
being overwritten.

@erlend-aasland
pythongh-105375: Improve errnomodule error handling
bf9f2c0
Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
@erlend-aaslanderlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@bedevere-botbedevere-bot mentioned this pull request Jun 9, 2023
Closed
18 tasks
@erlend-aasland
erlend-aasland merged commit eede1d2 into python:mainJun 9, 2023
@miss-islington

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland
erlend-aasland deleted the improve-errno-error-handling branch June 9, 2023 19:57
@miss-islington

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker eede1d2f48b4fe7f7918952d9ebeb744b58668c1 3.12

@miss-islington

miss-islington commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eede1d2f48b4fe7f7918952d9ebeb744b58668c1 3.11

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 9, 2023
@erlend-aasland
[3.11]pythongh-105375: Improve errnomodule error handling (python#10…
0562cbf
…5590)
(cherry picked from commit eede1d2)
Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 9, 2023
@erlend-aasland
[3.12]pythongh-105375: Improve errnomodule error handling (python#10…
417e84c
…5590)
(cherry picked from commit eede1d2)
Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot

bedevere-bot commented Jun 9, 2023

Copy link
Copy Markdown

GH-105595 is a backport of this pull request to the 3.11 branch.

@bedevere-bot

bedevere-bot commented Jun 9, 2023

Copy link
Copy Markdown

GH-105596 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 9, 2023
@erlend-aaslanderlend-aasland linked an issue Jun 9, 2023 that may be closed by this pull request
Incorrect error handling for APIs that can raise exceptions #105375
Closed
18 tasks
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
@erlend-aasland
[3.11]gh-105375: Improve errnomodule error handling (#105590) (#105595)
76682ba
(cherry picked from commit eede1d2)
Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
@erlend-aasland
[3.12]gh-105375: Improve errnomodule error handling (#105590) (#105596)
e0087df
(cherry picked from commit eede1d2)
Bail immediately if an exception is set, to prevent exceptions from
being overwritten.
@erlend-aaslanderlend-aasland mentioned this pull request Aug 27, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions

3 participants

@erlend-aasland@miss-islington@bedevere-bot