Skip to content

gh-105708: 'V' could be case insensitive for IPvFuture hostnames - #105709

Merged
orsenthil merged 6 commits into
python:mainfrom
csreddy98:IPvFuture-v-is-case-insensitive
Jul 5, 2026
Merged

gh-105708: 'V' could be case insensitive for IPvFuture hostnames#105709
orsenthil merged 6 commits into
python:mainfrom
csreddy98:IPvFuture-v-is-case-insensitive

Conversation

@csreddy98

@csreddy98csreddy98 commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

As per the standards the 'v' could be case-insensitive as mentioned here.

issue: GH-105708

@bedevere-bot

bedevere-bot commented Jun 12, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-botbedevere-bot mentioned this pull request Jun 12, 2023
Closed
@ghost

ghost commented Jun 12, 2023•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev

arhadthedev commented Jun 13, 2023

Copy link
Copy Markdown
Member

@orsenthil (as an urllib expert)

@github-actions

github-actionsBot commented Apr 13, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 13, 2026
@orsenthil
orsenthilforce-pushed the IPvFuture-v-is-case-insensitive branch from 6b0e9ab to fb1de1aCompareJuly 5, 2026 12:12
orsenthil
orsenthil reviewed Jul 5, 2026
View reviewed changes
Comment threadLib/urllib/parse.py Outdated
orsenthil
orsenthil reviewed Jul 5, 2026
View reviewed changes
Comment threadLib/test/test_urlparse.py
@orsenthilorsenthil removed the stale Stale PR or inactive for long period of time. label Jul 5, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Jul 5, 2026
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Comment threadMisc/NEWS.d/next/Library/2023-06-12-21-31-02.gh-issue-105708.5fFwP8.rst Outdated
@orsenthil
orsenthilforce-pushed the IPvFuture-v-is-case-insensitive branch from 7593d8a to d90aa84CompareJuly 5, 2026 16:03
@orsenthilorsenthil added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 5, 2026
@orsenthil
orsenthil merged commit a47a66c into python:mainJul 5, 2026
57 checks passed
@miss-islington-app

miss-islington-appBot commented Jul 5, 2026

Copy link
Copy Markdown

Thanks @csreddy98 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153138 is a backport of this pull request to the 3.15 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 5, 2026
@miss-islington-app

miss-islington-appBot commented Jul 5, 2026

Copy link
Copy Markdown

Sorry, @csreddy98 and @orsenthil, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a47a66ccef0f98fcf088bc260ca14b889efa9b04 3.13

@bedevere-app

bedevere-appBot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153139 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2026
orsenthil added a commit that referenced this pull request Jul 5, 2026
@miss-islington@csreddy98
@blurb-it@orsenthil
[3.15]gh-105708: 'V' could be case insensitive for IPvFuture hostnam…
986322e
…es (GH-105709) (#153138)
gh-105708: 'V' could be case insensitive for IPvFuture hostnames (GH-105709)
* gh-105708: 'V' could be case insensitive for IPvFuture hostnames
* gh-105708: 'V' could be case insensitive for IPvFuture hostnames & checking empty hostnames
* 📜🤖 Added by blurb_it.
* Fix the Merge changing \z to \Z.
* Fixed the News Entry.
* Fix the lint.
---------
(cherry picked from commit a47a66c)
Co-authored-by: Chandra <csreddy1998@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Senthil Kumaran <senthil@python.org>
orsenthil added a commit that referenced this pull request Jul 5, 2026
@miss-islington@csreddy98
@blurb-it@orsenthil
[3.14]gh-105708: 'V' could be case insensitive for IPvFuture hostnam…
85c58cf
…es (GH-105709) (#153139)
gh-105708: 'V' could be case insensitive for IPvFuture hostnames (GH-105709)
* gh-105708: 'V' could be case insensitive for IPvFuture hostnames
* gh-105708: 'V' could be case insensitive for IPvFuture hostnames & checking empty hostnames
* 📜🤖 Added by blurb_it.
* Fix the Merge changing \z to \Z.
* Fixed the News Entry.
* Fix the lint.
---------
(cherry picked from commit a47a66c)
Co-authored-by: Chandra <csreddy1998@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Senthil Kumaran <senthil@python.org>
@orsenthil

orsenthil commented Jul 5, 2026

Copy link
Copy Markdown
Member

I could not cleanly backport this to 3.13 due to a conflict.

Manually created here #153140

orsenthil added a commit that referenced this pull request Jul 5, 2026
@orsenthil@csreddy98@blurb-it
[3.13]gh-105708: 'V' could be case insensitive for IPvFuture hostnam…
491d830
…es (#5709) (#153140)
gh-105708: 'V' could be case insensitive for IPvFuture hostnames (#105709)
* gh-105708: 'V' could be case insensitive for IPvFuture hostnames
* gh-105708: 'V' could be case insensitive for IPvFuture hostnames & checking empty hostnames
* 📜🤖 Added by blurb_it.
* Fix the Merge changing \z to \Z.
* Fixed the News Entry.
* Fix the lint.
---------
(cherry picked from commit a47a66c)
Co-authored-by: Chandra <csreddy1998@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@StanFromIrelandStanFromIreland removed the needs backport to 3.13 bugs and security fixes label Jul 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthilorsenthilorsenthil left review comments
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

@orsenthilorsenthil

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csreddy98@bedevere-bot@arhadthedev@orsenthil@serhiy-storchaka@StanFromIreland