Skip to content

[3.11] gh-105375: Explicitly initialise all {Pickler,Unpickler}Object fields (#105686) - #105711

Merged
kumaraditya303 merged 2 commits into
python:3.11from
erlend-aasland:backport-3.11-fix-pickle-newgcobj
Jun 13, 2023
Merged

[3.11] gh-105375: Explicitly initialise all {Pickler,Unpickler}Object fields (#105686)#105711
kumaraditya303 merged 2 commits into
python:3.11from
erlend-aasland:backport-3.11-fix-pickle-newgcobj

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

All fields must be explicitly initialised to prevent manipulation of
uninitialised fields in dealloc.

Align initialisation order with the layout of the object structs.

(cherry picked from commit ca3cc4b)

Co-authored-by: Erlend E. Aasland erlend.aasland@protonmail.com

…Object fields (python#105686)
All fields must be explicitly initialised to prevent manipulation of
uninitialised fields in dealloc.
Align initialisation order with the layout of the object structs.
(cherry picked from commit ca3cc4b)
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@kumaraditya303

Copy link
Copy Markdown
Contributor

Retrigged CI

@kumaraditya303
kumaraditya303 merged commit 36c393c into python:3.11Jun 13, 2023
@erlend-aasland
erlend-aasland deleted the backport-3.11-fix-pickle-newgcobj branch June 13, 2023 07:05
@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

Thanks, Kumar!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland@kumaraditya303@bedevere-bot