Skip to content

gh-105908: fix barry_as_FLUFL future import - #105909

Merged
iritkatriel merged 6 commits into
python:mainfrom
thatbirdguythatuknownot:patch-31
Jun 19, 2023
Merged

gh-105908: fix barry_as_FLUFL future import#105909
iritkatriel merged 6 commits into
python:mainfrom
thatbirdguythatuknownot:patch-31

Conversation

@thatbirdguythatuknownot

@thatbirdguythatuknownotthatbirdguythatuknownot commented Jun 19, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

In compiler_setup(), the flags parameter is a local struct that does not reflect changes to the pointer passed to new_compiler(). Fix by making the flags parameter a pointer to a struct instead of a struct.

@bedevere-botbedevere-bot mentioned this pull request Jun 19, 2023
Closed
@iritkatriel

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

Is there no test for this?

@thatbirdguythatuknownot

thatbirdguythatuknownot commented Jun 19, 2023

Copy link
Copy Markdown
ContributorAuthor

Is there no test for this?

I'm currently adding it.

Eclips4
Eclips4 reviewed Jun 19, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Core and Builtins/2023-06-19-11-04-01.gh-issue-105908.7oanny.rst Outdated
@thatbirdguythatuknownot@Eclips4
fix news markdown
6815da7
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@iritkatriel

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

Thank you @thatbirdguythatuknownot .

@iritkatrieliritkatriel added the type-bug An unexpected behavior, bug, or error label Jun 19, 2023
@iritkatriel

iritkatriel commented Jun 19, 2023

Copy link
Copy Markdown
Member

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?

@thatbirdguythatuknownot

thatbirdguythatuknownot commented Jun 19, 2023

Copy link
Copy Markdown
ContributorAuthor

@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR?

It must be from flags = &_PyCompilerFlags_INIT. I could probably bring back the local_flags variable to prevent it.

@iritkatriel
iritkatriel merged commit 28187a9 into python:mainJun 19, 2023
@sunmy2019

sunmy2019 commented Jun 20, 2023

Copy link
Copy Markdown
Member

Thanks! This change makes sense.

@JelleZijlstra

JelleZijlstra commented Jun 20, 2023

Copy link
Copy Markdown
Member

Does this need to be backported to 3.12?

@JelleZijlstraJelleZijlstra added the needs backport to 3.12 only security fixes label Jun 20, 2023
@miss-islington

miss-islington commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @thatbirdguythatuknownot for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 20, 2023

Copy link
Copy Markdown

GH-105930 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2023
@thatbirdguythatuknownot@miss-islington
pythongh-105908: fixbarry_as_FLUFLfuture import (pythonGH-105909)
32335a2
(cherry picked from commit 28187a9)
Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com>
JelleZijlstra pushed a commit that referenced this pull request Jun 20, 2023
@miss-islington@thatbirdguythatuknownot
[3.12]gh-105908: fixbarry_as_FLUFLfuture import (GH-105909) (#10…
cc18a8b
…5930)
(cherry picked from commit 28187a9)
Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4Eclips4Eclips4 left review comments
@iritkatrieliritkatrieliritkatriel approved these changes
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thatbirdguythatuknownot@iritkatriel@sunmy2019@JelleZijlstra@miss-islington@bedevere-bot@Eclips4