Skip to content

GH-105808: Fix a regression introduced in GH-101251 - #105910

Merged
gpshead merged 4 commits into
python:mainfrom
Yhg1s:gzip-flush
Jun 19, 2023
Merged

GH-105808: Fix a regression introduced in GH-101251#105910
gpshead merged 4 commits into
python:mainfrom
Yhg1s:gzip-flush

Conversation

@Yhg1s

@Yhg1sYhg1s commented Jun 19, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fix a regression introduced in GH-101251, causing GzipFile.flush() to not flush the compressor (nor pass along the zip_mode argument).

@Yhg1s
Fix a regression introduced inpythonGH-101251, causing GzipFile.flus…
5b3a658
…h() to
not flush the compressor (nor pass along the zip_mode argument).
@bedevere-botbedevere-bot mentioned this pull request Jun 19, 2023
Closed
@Yhg1s
Yhg1s requested review from ambv and gpsheadJune 19, 2023 11:32
@gpsheadgpshead added the needs backport to 3.12 only security fixes label Jun 19, 2023
@gpshead
gpshead enabled auto-merge (squash) June 19, 2023 16:40
@gpshead
gpshead merged commit 1858db7 into python:mainJun 19, 2023
@miss-islington

miss-islington commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Thanks @Yhg1s for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 19, 2023

Copy link
Copy Markdown

GH-105920 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2023
@Yhg1s@miss-islington
pythonGH-105808: Fix a regression introduced inpythonGH-101251(pyth…
15b4976
…onGH-105910)
Fix a regression introduced in pythonGH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)
Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jun 19, 2023
Yhg1s added a commit that referenced this pull request Jun 19, 2023
@miss-islington@Yhg1s
[3.12]GH-105808: Fix a regression introduced inGH-101251(GH-105910) (
225cc4c
#105920)
GH-105808: Fix a regression introduced in GH-101251 (GH-105910)
Fix a regression introduced in GH-101251, causing GzipFile.flush() to
not flush the compressor (nor pass along the zip_mode argument).
(cherry picked from commit 1858db7)
Co-authored-by: T. Wouters <thomas@python.org>
@Yhg1s
Yhg1s deleted the gzip-flush branch November 22, 2023 15:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes
@ambvambvAwaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yhg1s@miss-islington@bedevere-bot@gpshead