Uh oh!
There was an error while loading. Please reload this page.
gh-105927: PyImport_AddModule() uses _PyWeakref_GET_REF() - #106001
Merged
Conversation
vstinner
requested review from
brettcannon, ericsnowcurrently, ncoghlan and warsaw
as code ownersJune 22, 2023 22:16
It now raises an exception if sys.modules doesn't hold a strong reference to the module. Elaborate the comment explaining why a weak reference is used to create a borrowed reference.
| Py_DECREF(ref); | ||
| Py_XDECREF(mod); | ||
| if (mod == NULL && !PyErr_Occurred()) { |
There was a problem hiding this comment.
I am not sure that comparing mod with NULL after Py_XDECREF does not have an undefined behavior. AFAIK, you can do nothing with a pointer to released memory, not even compare it with NULL.
MemberAuthor
There was a problem hiding this comment.
See comments of my PR #105998: IMO most of this code is useless and can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now raises an exception if sys.modules doesn't hold a strong reference to the module.
Elaborate the comment explaining why a weak reference is used to create a borrowed reference.