Skip to content

gh-104683: Modernise Argument Clinic parameter state machine - #106362

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/param-state-machine
Jul 3, 2023
Merged

gh-104683: Modernise Argument Clinic parameter state machine#106362
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/param-state-machine

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 3, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Use enum and pattern matching to make the code more readable.

@bedevere-botbedevere-bot mentioned this pull request Jul 3, 2023
Closed
7 tasks
AlexWaygood
AlexWaygood reviewed Jul 3, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea; this is a big improvement in my opinion. A few small comments, mostly about idiomatic usage of enums:

Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
Comment threadTools/clinic/clinic.py Outdated
@AlexWaygood

AlexWaygood commented Jul 3, 2023

Copy link
Copy Markdown
Member

(I take it you've checked that all this code is well covered by our tests? :)

arhadthedev
arhadthedev reviewed Jul 3, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
@erlend-aasland

erlend-aasland commented Jul 3, 2023

Copy link
Copy Markdown
ContributorAuthor

(I take it you've checked that all this code is well covered by our tests? :)

It's pretty good checked; I ran into test failures bco. some hickups during implementation :) However, I'll do a proper coverage check before landing.

@erlend-aasland@arhadthedev@AlexWaygood
Apply suggestions from code review
4695271
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood reviewed Jul 3, 2023
View reviewed changes
Comment threadTools/clinic/clinic.py
AlexWaygood
AlexWaygood approved these changes Jul 3, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, providing the test coverage is good. I left a comment about a possible enhancement you could do with the enum, but I think it's probably a case of YAGNI.

@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 3, 2023 20:48
@erlend-aasland
erlend-aasland merged commit 71b4044 into python:mainJul 3, 2023
@erlend-aasland
erlend-aasland deleted the clinic/param-state-machine branch July 3, 2023 21:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedevarhadthedevarhadthedev left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@AlexWaygood@arhadthedev@bedevere-bot