Skip to content

gh-106368: Increase Argument Clinic test coverage - #106369

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:clinic/expand-param-state-tests
Jul 3, 2023
Merged

gh-106368: Increase Argument Clinic test coverage#106369
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:clinic/expand-param-state-tests

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Add tests for 'self' and 'defining_class' converter requirements.

Add tests for 'self' and 'defining_class' converter requirements.
@erlend-aasland

Copy link
Copy Markdown
ContributorAuthor

I consider this an uncontroversial change; will merge when CI is green.

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@erlend-aasland
erlend-aasland merged commit 7f4c812 into python:mainJul 3, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7f4c8121db62a9f72f00f2d9f73381e82f289581 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
)
Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-106370 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 3, 2023
@erlend-aasland
erlend-aasland deleted the clinic/expand-param-state-tests branch July 3, 2023 20:33
@bedevere-bot

Copy link
Copy Markdown

GH-106374 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 3, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 3, 2023
…n#106369)
Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
…106370)
Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
…106374)
Add tests for 'self' and 'defining_class' converter requirements.
(cherry picked from commit 7f4c812)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@miss-islington@bedevere-bot@sobolevn