Skip to content

gh-106368: Clean up Argument Clinic tests - #106373

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/clean-up-tests
Jul 3, 2023
Merged

gh-106368: Clean up Argument Clinic tests#106373
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/clean-up-tests

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 3, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 3, 2023
@bedevere-botbedevere-bot mentioned this pull request Jul 3, 2023
Closed
@erlend-aasland

erlend-aasland commented Jul 3, 2023

Copy link
Copy Markdown
ContributorAuthor

If we're going to increase coverage for Argument Clinic, we need to clean up the test code a little bit; we need readable tests, and we need to be able to debug existing tests without pulling our hair.

sobolevn
sobolevn reviewed Jul 3, 2023
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, in my opinion, it is much more readable now.

Comment threadLib/test/test_clinic.py
Comment threadLib/test/test_clinic.py Outdated
sobolevn
sobolevn approved these changes Jul 3, 2023
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 3, 2023 21:32
@erlend-aasland

erlend-aasland commented Jul 3, 2023

Copy link
Copy Markdown
ContributorAuthor

After gh-106373, we should make the test_disallowed_* tests more accurate. Most of them simply run self.parse_function_should_fail without checking the error message. This makes it hard to verify that the test is checking the right path.

@erlend-aasland
erlend-aasland merged commit 3ee8dac into python:mainJul 3, 2023
@miss-islington

miss-islington commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3ee8dac7a1b3882aa3aac7703bdae2de7b6402ad 3.12

@miss-islington

miss-islington commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 3ee8dac7a1b3882aa3aac7703bdae2de7b6402ad 3.11

@bedevere-bot

bedevere-bot commented Jul 3, 2023

Copy link
Copy Markdown

GH-106379 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 3, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 3, 2023
@erlend-aasland
[3.12]pythongh-106368: Clean up Argument Clinic tests (python#106373)
e3a1cbd
(cherry picked from commit 3ee8dac)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aasland
erlend-aasland deleted the clinic/clean-up-tests branch July 3, 2023 22:04
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 3, 2023
@erlend-aasland
[3.11]pythongh-106368: Clean up Argument Clinic tests (python#106373)
098f500
(cherry picked from commit 3ee8dac)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot

bedevere-bot commented Jul 3, 2023

Copy link
Copy Markdown

GH-106381 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 3, 2023
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
@erlend-aasland
[3.12]gh-106368: Clean up Argument Clinic tests (#106373) (#106379)
38fe0e7
(cherry picked from commit 3ee8dac)
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
@erlend-aasland
[3.11]gh-106368: Clean up Argument Clinic tests (#106373) (#106381)
3fdda97
(cherry picked from commit 3ee8dac)
carljm added a commit to carljm/cpython that referenced this pull request Jul 4, 2023
@carljm
Merge branch 'main' into cachedpropdoublecheck
7a7fd43
* main:
pythongh-106368: Increase Argument Clinic test coverage (python#106389)
pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386)
pythongh-106368: Harden Argument Clinic parser tests (python#106384)
pythongh-106320: Remove private _PyImport C API functions (python#106383)
pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377)
pythongh-106320: Remove more private _PyUnicode C API functions (python#106382)
pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376)
pythongh-106368: Clean up Argument Clinic tests (python#106373)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@miss-islington@bedevere-bot@sobolevn