Skip to content

gh-104469 Convert_testcapi/vectorcall.c to use AC - #106557

Merged
corona10 merged 6 commits into
python:mainfrom
littlebutt:main
Jul 9, 2023
Merged

gh-104469 Convert_testcapi/vectorcall.c to use AC#106557
corona10 merged 6 commits into
python:mainfrom
littlebutt:main

Conversation

@littlebutt

@littlebuttlittlebutt commented Jul 9, 2023

Copy link
Copy Markdown
Contributor

@bedevere-bot

bedevere-bot commented Jul 9, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-botbedevere-bot mentioned this pull request Jul 9, 2023
Closed
@ghost

ghost commented Jul 9, 2023•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@corona10
corona10 self-requested a review July 9, 2023 03:13
sobolevn
sobolevn reviewed Jul 9, 2023
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we need to convert test_ prefixed functions. They are executed as tests directly.

@corona10

corona10 commented Jul 9, 2023

Copy link
Copy Markdown
Member

I don't think that we need to convert test_ prefixed functions. They are executed as tests directly.

Well, I am okay with it. We already did.
#104720

corona10
corona10 requested changes Jul 9, 2023
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First thing, method names are wrong.
Please change method names and then executing the make clinic

Comment threadModules/_testcapi/vectorcall.c Outdated
}

/*[clinic input]
_testcapi.test_pyobject_fastcalldict

@corona10corona10Jul 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_testcapi.test_pyobject_fastcalldict
_testcapi.pyobject_fastcalldict

Comment threadModules/_testcapi/vectorcall.c Outdated
}

/*[clinic input]
_testcapi.test_pyobject_vectorcall

@corona10corona10Jul 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_testcapi.test_pyobject_vectorcall
_testcapi.pyvectorcall_call

Comment threadModules/_testcapi/vectorcall.c Outdated
_testcapi.test_pyobject_vectorcall
func: object
func_args: object
kwnames: object = NULL

@corona10corona10Jul 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kwnames: object=NULL
kwnames: object=None

Comment threadModules/_testcapi/vectorcall.c Outdated
}

/*[clinic input]
_testcapi.test_pyvectorcall_call

@corona10corona10Jul 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_testcapi.test_pyvectorcall_call
_testcapi.pyvectorcall_call

@bedevere-bot

bedevere-bot commented Jul 9, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-bot

bedevere-bot commented Jul 9, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@littlebutt

littlebutt commented Jul 9, 2023

Copy link
Copy Markdown
ContributorAuthor

@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases.

@corona10

corona10 commented Jul 9, 2023

Copy link
Copy Markdown
Member

@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases.

According to CI, it looks not, did you rebuild the code?

@littlebutt

littlebutt commented Jul 9, 2023

Copy link
Copy Markdown
ContributorAuthor

@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases.

According to CI, it looks not, did you rebuild the code?

No, I didn't. I just ran rt.bat -q test_capi directly after generating .c.h file😂. Thank you for help and I learnt a lot.

corona10
corona10 reviewed Jul 9, 2023
View reviewed changes
Comment threadModules/_testcapi/vectorcall.c Outdated
corona10
corona10 approved these changes Jul 9, 2023
View reviewed changes

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10
corona10 merged commit d137c2c into python:mainJul 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments
@corona10corona10corona10 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@littlebutt@bedevere-bot@corona10@sobolevn