Uh oh!
There was an error while loading. Please reload this page.
Added documentation describing the dklen is expected in bytes for the… - #106624
Merged
Conversation
… hashlib.pbkdf2_hmac function.
All commit authors signed the Contributor License Agreement. |
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
There is a similar case in the documentation for scrypt() few lines below. Please add "in bytes" there too.
thiezn
commented
May 22, 2024
ContributorAuthor
Updated dklen documentation for scrypt() to include 'in bytes' |
Thanks @thiezn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2024
…thonGH-106624) (cherry picked from commit 5adf78f) Co-authored-by: Mathijs Mortimer <thiezn@users.noreply.github.com>
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2024
…thonGH-106624) (cherry picked from commit 5adf78f) Co-authored-by: Mathijs Mortimer <thiezn@users.noreply.github.com>
GH-119383 is a backport of this pull request to the 3.13 branch. |
GH-119384 is a backport of this pull request to the 3.12 branch. |
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update hashlib.pbkdf2_hmac docs that dklen is in bytes
The hashlib.pbkfdf2_hmac documentation states that you can pass on the length of the derived key. It is however ambiguous if it's meant to be passed on as bytes or bits.
The CPython implementation relies on the OpenSSL C library. Looking at the OpenSSL source code, the function is expected to be in bytes.
Although this might be obvious to most people, some other language libraries handle this in bits.
Ps. This is my first pull request to cPython. I hope I'm not missing anything?
📚 Documentation preview 📚: https://cpython-previews--106624.org.readthedocs.build/