Skip to content

gh-106368: Increase Argument Clinic test coverage - #106728

Merged
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:clinic/coverage-defining-class-alt
Jul 13, 2023
Merged

gh-106368: Increase Argument Clinic test coverage#106728
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:clinic/coverage-defining-class-alt

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • improve output_parameter() coverage
  • improve coverage for Function.kind

@bedevere-botbedevere-bot mentioned this pull request Jul 4, 2023
Closed
@erlend-aaslanderlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 13, 2023
@AlexWaygood

AlexWaygood commented Jul 13, 2023

Copy link
Copy Markdown
Member

I'm probably not the best reviewer for this one, but this all looks reasonable!

@erlend-aasland

erlend-aasland commented Jul 13, 2023

Copy link
Copy Markdown
ContributorAuthor

I'm probably not the best reviewer for this one, but this all looks reasonable!

Thanks! I'll expand this PR so we've got better coverage for your FunctionKind PR.

@erlend-aaslanderlend-aasland changed the title gh-106368: Argument Clinic: Increase coverage for output_parameters()gh-106368: Increase Argument Clinic test coverageJul 13, 2023
@erlend-aasland

erlend-aasland commented Jul 13, 2023

Copy link
Copy Markdown
ContributorAuthor

With this, we're up to approx. 86% test coverage.

@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 13, 2023 22:17
@erlend-aasland
erlend-aasland merged commit ec45c51 into python:mainJul 13, 2023
@miss-islington

miss-islington commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ec45c513d389510930a62631a21a1dbb3f3aabb7 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2023
@erlend-aasland@miss-islington
pythongh-106368: Increase Argument Clinic test coverage (pythonGH-106728
604c2ce
)
- improve output_parameter() coverage
- improve coverage for Function.kind
(cherry picked from commit ec45c51)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot

bedevere-bot commented Jul 13, 2023

Copy link
Copy Markdown

GH-106730 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 13, 2023
@erlend-aasland
erlend-aasland deleted the clinic/coverage-defining-class-alt branch July 13, 2023 22:19
@bedevere-bot

bedevere-bot commented Jul 13, 2023

Copy link
Copy Markdown

GH-106731 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 13, 2023
erlend-aasland added a commit that referenced this pull request Jul 13, 2023
@miss-islington@erlend-aasland
[3.12]gh-106368: Increase Argument Clinic test coverage (GH-106728) (#…
6a1a660
…106730)
- improve output_parameter() coverage
- improve coverage for Function.kind
(cherry picked from commit ec45c51)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
erlend-aasland added a commit that referenced this pull request Jul 13, 2023
@erlend-aasland
[3.11]gh-106368: Increase Argument Clinic test coverage (#106728) (#…
d22224a
…106731)
- improve output_parameter() coverage
- improve coverage for Function.kind
(cherry picked from commit ec45c51)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
* Fix merge
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
kgdiem pushed a commit to kgdiem/cpython that referenced this pull request Jul 14, 2023
@erlend-aasland@kgdiem
pythongh-106368: Increase Argument Clinic test coverage (python#106728)
9acddfa
- improve output_parameter() coverage
- improve coverage for Function.kind
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees

@erlend-aaslanderlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@AlexWaygood@miss-islington@bedevere-bot