Skip to content

gh-106669: Revert "gh-102988: Detect email address parsing errors ... (#105127)" - #106733

Merged
gpshead merged 4 commits into
python:mainfrom
gpshead:gh-106669
Jul 21, 2023
Merged

gh-106669: Revert "gh-102988: Detect email address parsing errors ... (#105127)"#106733
gpshead merged 4 commits into
python:mainfrom
gpshead:gh-106669

Conversation

@gpshead

@gpsheadgpshead commented Jul 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member

gh-106669: Revert "gh-102988: Detect email address parsing errors and return empty tuple to indicate the parsing error (old API) (#105127)"

This reverts commit 18dfbd0 and adds the regression test suggested in the issue.

See #106669.

📚 Documentation preview 📚: https://cpython-previews--106733.org.readthedocs.build/

@gpshead
pythongh-106669: Revert "pythongh-102988: Detect email address parsin…
362793e
…g errors and return empty tuple to indicate the parsing error (old API) (python#105127)"
This reverts commit 18dfbd0.
See python#106669.
@gpshead
Keep a news entry. Describe the revert and bug.
c8f5af2
@gpsheadgpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.12 only security fixes labels Jul 14, 2023
@bedevere-botbedevere-bot mentioned this pull request Jul 14, 2023
Closed
@gpshead
gpshead marked this pull request as ready for review July 14, 2023 00:55
@gpshead
gpshead requested a review from a team as a code ownerJuly 14, 2023 00:55
@gpsheadgpshead self-assigned this Jul 14, 2023
@gpshead
gpshead requested a review from Yhg1sJuly 14, 2023 00:56
@felixxmfelixxm mentioned this pull request Jul 17, 2023
Merged
@gpshead
gpshead merged commit a31dea1 into python:mainJul 21, 2023
@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @gpshead, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

@gpshead
gpshead deleted the gh-106669 branch July 21, 2023 03:30
@gpsheadgpshead added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 21, 2023
@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Sorry @gpshead, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

@gpsheadgpshead added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jul 21, 2023
@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Sorry @gpshead, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a31dea1feb61793e48fa9aa5014f358352205c1d 3.12

gpshead added a commit to gpshead/cpython that referenced this pull request Jul 21, 2023
@gpshead
[3.12]pythongh-106669: Revert "pythongh-102988: Detect email address…
4288c62
… parsing errors ... (pythonGH-105127)" (pythonGH-106733)
This reverts commit 18dfbd0.
Adds a regression test from the issue.
See python#106669..
(cherry picked from commit a31dea1)
Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot

bedevere-bot commented Jul 21, 2023

Copy link
Copy Markdown

GH-106941 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 21, 2023
gpshead added a commit that referenced this pull request Jul 21, 2023
@gpshead
[3.12]gh-106669: Revert "gh-102988: Detect email address parsing err…
656f624
…ors ... (GH-105127)" (GH-106733) (#106941)
This reverts commit 18dfbd0.
Adds a regression test from the issue.
See #106669..
(cherry picked from commit a31dea1)
@gpsheadgpshead mentioned this pull request Dec 14, 2023
Merged
@smosersmoser mentioned this pull request Feb 23, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1sYhg1sAwaiting requested review from Yhg1s

Assignees

@gpsheadgpshead

Labels

release-blockertype-bugAn unexpected behavior, bug, or error

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpshead@miss-islington@bedevere-bot