Skip to content

gh-104090: Fix unittest collectedDurations resources leak - #106795

Merged
iritkatriel merged 4 commits into
python:mainfrom
bityob:gh-104090-fix-leaked-semaphors-on-test_concurrent_futures
Jul 19, 2023
Merged

gh-104090: Fix unittest collectedDurations resources leak#106795
iritkatriel merged 4 commits into
python:mainfrom
bityob:gh-104090-fix-leaked-semaphors-on-test_concurrent_futures

Conversation

@bityob

@bityobbityob commented Jul 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Fixed TestResult.addDuration method to add only test repr string and not the test object itself, to avoid resources leak

@iritkatriel

@bedevere-bot

bedevere-bot commented Jul 15, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-botbedevere-bot mentioned this pull request Jul 15, 2023
Open
@bityob
bityobforce-pushed the gh-104090-fix-leaked-semaphors-on-test_concurrent_futures branch from cdbe1c4 to 8cd162fCompareJuly 16, 2023 08:53
@iritkatriel

iritkatriel commented Jul 16, 2023

Copy link
Copy Markdown
Member

I think it might be better to split this into two PRs (attached to the same issue), one for the unittest fix and the other for the resource tracker change.

@bityob
bityobforce-pushed the gh-104090-fix-leaked-semaphors-on-test_concurrent_futures branch from 5585599 to 509636aCompareJuly 16, 2023 11:58
@bedevere-bot

bedevere-bot commented Jul 16, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bityob

bityob commented Jul 16, 2023

Copy link
Copy Markdown
ContributorAuthor

I think it might be better to split this into two PRs (attached to the same issue), one for the unittest fix and the other for the resource tracker change.

Done

Second PR: #106807

@iritkatrieliritkatriel added tests Tests in the Lib/test dir stdlib Standard Library Python modules in the Lib/ directory labels Jul 16, 2023
@iritkatriel

iritkatriel commented Jul 16, 2023

Copy link
Copy Markdown
Member

CC unittest maintainers. @gpshead@ezio-melotti

See issue for motivation.

@iritkatriel

iritkatriel commented Jul 17, 2023

Copy link
Copy Markdown
Member

@giampaolo addDuration was added in 3.12. Should this be backported as a bugfix?

@sunmy2019

sunmy2019 commented Jul 18, 2023

Copy link
Copy Markdown
Member

Is this new entry necessary?

Should this be backported as a bugfix?

+1 from me

@sunmy2019sunmy2019 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2023
@bedevere-bot

bedevere-bot commented Jul 18, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sunmy2019 for commit d493239 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 18, 2023
@iritkatrieliritkatriel added the needs backport to 3.12 only security fixes label Jul 18, 2023
@sunmy2019sunmy2019 mentioned this pull request Jul 19, 2023
Closed
iritkatriel
iritkatriel reviewed Jul 19, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Tests/2023-07-16-02-57-08.gh-issue-104090.cKtK7g.rst Outdated
@giampaolo

giampaolo commented Jul 19, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@iritkatriel wrote:

@giampaolo addDuration was added in 3.12. Should this be backported as a bugfix?

Hi! Yes, I think it should be backported.

@iritkatriel
iritkatriel merged commit 70b961e into python:mainJul 19, 2023
@miss-islington

miss-islington commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

Thanks @bityob for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 19, 2023

Copy link
Copy Markdown

GH-106888 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2023
@bityob@miss-islington
pythongh-104090: Fix unittest collectedDurations resources leak (pyth…
8b1fdec
…onGH-106795)
(cherry picked from commit 70b961e)
Co-authored-by: Yonatan Bitton <bityob@gmail.com>
@iritkatrieliritkatriel added the needs backport to 3.12 only security fixes label Jul 19, 2023
@miss-islington

miss-islington commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

Thanks @bityob for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2023
@bityob@miss-islington
pythongh-104090: Fix unittest collectedDurations resources leak (pyth…
e0a4576
…onGH-106795)
(cherry picked from commit 70b961e)
Co-authored-by: Yonatan Bitton <bityob@gmail.com>
iritkatriel pushed a commit that referenced this pull request Jul 19, 2023
@miss-islington@bityob
[3.12]gh-104090: Fix unittest collectedDurations resources leak (GH-…
b1c50b8
…106795) (#106888)
gh-104090: Fix unittest collectedDurations resources leak (GH-106795)
(cherry picked from commit 70b961e)
Co-authored-by: Yonatan Bitton <bityob@gmail.com>
@gpshead

gpshead commented Jul 19, 2023

Copy link
Copy Markdown
Member

thanks for figuring this out!

@picnixzpicnixz removed the needs backport to 3.12 only security fixes label Sep 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes
@giampaologiampaoloAwaiting requested review from giampaolo

Assignees

No one assigned

Labels

stdlibStandard Library Python modules in the Lib/ directorytestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bityob@bedevere-bot@iritkatriel@sunmy2019@giampaolo@miss-islington@gpshead@picnixz