Skip to content

gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB - #106826

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-106693
May 7, 2026
Merged

gh-106693: Explicitly mark ob_sval as unsigned char to avoid UB#106826
pablogsal merged 2 commits into
python:mainfrom
pablogsal:gh-106693

Conversation

@pablogsal

@pablogsalpablogsal commented Jul 17, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsalpablogsal added the needs backport to 3.12 only security fixes label Jul 17, 2023
@bedevere-botbedevere-bot mentioned this pull request Jul 17, 2023
Open
@pablogsal
pythongh-106693: Explicitly mark ob_sval as unsigned char to avoid UB
eecd6a8
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 9, 2024
@tomasr8tomasr8 removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@pablogsal
pablogsal enabled auto-merge (squash) September 19, 2025 10:14
@github-actions

github-actionsBot commented Apr 13, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Apr 13, 2026
@pablogsal
pablogsal merged commit fbba343 into python:mainMay 7, 2026
19 of 45 checks passed
@pablogsal
pablogsal deleted the gh-106693 branch May 7, 2026 19:06
@miss-islington-app

miss-islington-appBot commented May 7, 2026

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@bedevere-app

bedevere-appBot commented May 7, 2026

Copy link
Copy Markdown

GH-149510 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.14 bugs and security fixes label May 7, 2026
@bedevere-app

bedevere-appBot commented May 7, 2026

Copy link
Copy Markdown

GH-149511 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 7, 2026
@colesbury

colesbury commented May 7, 2026

Copy link
Copy Markdown
Contributor

@pablogsal I might be missing something, but it looks like this breaks a bunch of builds. Doesn't it also have a bunch backwards compatibility concerns? The theoretically fixes undefined behavior seems less important than the actual breaks backwards compatibility

@pablogsal

pablogsal commented May 7, 2026

Copy link
Copy Markdown
MemberAuthor

I didn't merge this myself so I don't know what the hell happened here

@pablogsal

pablogsal commented May 7, 2026

Copy link
Copy Markdown
MemberAuthor

(Apparently this is a consequence of deactivating branch protections in the release)

hugovk added a commit that referenced this pull request May 7, 2026
@hugovk
gh-106693: Revert "Explicitly mark ob_sval as unsigned char to avoid …
f0daba1
…UB (#106826)" (#149514)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip newsstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal@colesbury@serhiy-storchaka@tomasr8@bedevere-bot