Uh oh!
There was an error while loading. Please reload this page.
gh-86493: Use PyModule_Add() instead of PyModule_AddObjectRef() - #106860
Merged
Conversation
serhiy-storchaka
requested review from
a team, brettcannon, ericsnowcurrently, ncoghlan and warsaw
as code ownersJuly 18, 2023 10:41
| int rc = PyModule_AddObjectRef(mod, "WITH_PYMALLOC", v); | ||
| Py_DECREF(v); | ||
| if (rc < 0) { | ||
| if (PyModule_AddObjectRef(mod, "WITH_PYMALLOC", v) < 0) { |
Member
There was a problem hiding this comment.
Was this purposefully not converted to PyModule_Add()?
MemberAuthor
There was a problem hiding this comment.
Yes, PyModule_AddObjectRef() is more fitting here. But the old code was complicated without need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
PyModule_AddObjectRef()followed byPy_DECREF()of the added value, the code can be simplified by usingPyModule_Add()which was designed specially for such cases.