Skip to content

gh-106078: Prepare to isolate decimal module - #106880

Merged
kumaraditya303 merged 3 commits into
python:mainfrom
CharlieZhao95:decimal/move_condmap
Jul 20, 2023
Merged

gh-106078: Prepare to isolate decimal module#106880
kumaraditya303 merged 3 commits into
python:mainfrom
CharlieZhao95:decimal/move_condmap

Conversation

@CharlieZhao95

@CharlieZhao95CharlieZhao95 commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

The DecCondMap contains a potentially global variable(ex, a subclass of DecimalException). We should also move signal_map and cond_map to module state.

  • Move signal_map and cond_map to global state
  • Initialize array of DecCondMap using heap memory (Prepare to isolate module)

@CharlieZhao95

Copy link
Copy Markdown
ContributorAuthor

@CharlieZhao95
CharlieZhao95 marked this pull request as ready for review July 19, 2023 07:04
@rhettinger
rhettinger removed their request for review July 19, 2023 19:54
@kumaraditya303

Copy link
Copy Markdown
Contributor
root@codespaces-62bef3 /w/cpython (decimal/move_condmap)# ./python -m test -R 3:3 test_decimal0:00:00 load avg: 37.18 Run tests sequentially0:00:00 load avg: 37.18 [1/1] test_decimalbeginning 6 repetitions123456......== Tests result: SUCCESS ==1 test OK.Total duration: 26.0 secTests result: SUCCESS

@kumaraditya303
kumaraditya303 enabled auto-merge (squash) July 20, 2023 09:23
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) July 20, 2023 09:23
@kumaraditya303
kumaraditya303 merged commit a1620dd into python:mainJul 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@CharlieZhao95@kumaraditya303@bedevere-bot