Uh oh!
There was an error while loading. Please reload this page.
gh-104050: Argument Clinic: Increase CConverter typing coverage - #106932
Merged
erlend-aasland merged 3 commits intoJul 20, 2023
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AlexWaygood
approved these changes
Jul 20, 2023
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
LGTM, providing the tests all pass with the default values removed!
erlend-aasland
enabled auto-merge (squash)
July 20, 2023 22:37
erlend-aasland
commented
Jul 20, 2023
ContributorAuthor
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.