Skip to content

gh-106368: Increase coverage for Argument Clinic output directive - #106979

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/coverage-output-directive
Jul 22, 2023
Merged

gh-106368: Increase coverage for Argument Clinic output directive#106979
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/coverage-output-directive

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 21, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Jul 21, 2023
Closed
@bedevere-botbedevere-bot added the tests Tests in the Lib/test dir label Jul 21, 2023
sobolevn
sobolevn approved these changes Jul 22, 2023
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question is not blocking :)
Thanks!

Comment threadLib/test/test_clinic.py
@erlend-aasland

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews!

@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 22, 2023 09:06
@erlend-aasland
erlend-aasland merged commit ee5c01b into python:mainJul 22, 2023
@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 22, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ee5c01b473eeadb007b9f330db3143e34e46038b 3.11

@bedevere-bot

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-106994 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 22, 2023
@erlend-aasland@miss-islington
pythongh-106368: Increase coverage for Argument Clinic output directi…
483c3d6
…ve (pythonGH-106979)
(cherry picked from commit ee5c01b)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot

bedevere-bot commented Jul 22, 2023

Copy link
Copy Markdown

GH-107002 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 22, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 22, 2023
@erlend-aasland@ambv
[3.11]pythongh-106368: Increase coverage for Argument Clinic output …
42dd5ce
…directive (pythonGH-106979)
(cherry picked from commit ee5c01b)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 22, 2023
@miss-islington@erlend-aasland
[3.12]gh-106368: Increase coverage for Argument Clinic output direct…
76fd98a
…ive (GH-106979) (#106994)
(cherry picked from commit ee5c01b)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aasland

erlend-aasland commented Jul 22, 2023

Copy link
Copy Markdown
ContributorAuthor

I'll fix the backport later, unless someone beats me to it :)

ambv added a commit that referenced this pull request Jul 22, 2023
@ambv@erlend-aasland
[3.11]gh-106368: Increase coverage for Argument Clinic output direct…
06f8a43
…ive (GH-106979) (#107002)
(cherry picked from commit ee5c01b)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aasland
erlend-aasland deleted the clinic/coverage-output-directive branch July 22, 2023 14:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments
@sobolevnsobolevnsobolevn approved these changes
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees

@erlend-aaslanderlend-aasland

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@miss-islington@bedevere-bot@ambv@sobolevn