Skip to content

gh-104050: Argument clinic: improve typing around adding C converters#107209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 1 commit into from
Jul 25, 2023
Merged

gh-104050: Argument clinic: improve typing around adding C converters #107209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,6 +44,7 @@
NoReturn,
Protocol,
TypeGuard,
TypeVar,
overload,
)

Expand DownExpand Up@@ -2647,10 +2648,12 @@ def __getattribute__(self, name: str) -> Any:
fail("Stepped on a land mine, trying to access attribute " + repr(name) + ":\n" + self.__message__)


CConverterClassT = TypeVar("CConverterClassT", bound=type["CConverter"])

def add_c_converter(
f: type[CConverter],
f: CConverterClassT,
name: str | None = None
) -> type[CConverter]:
) -> CConverterClassT:
Comment on lines +2651 to +2656

@AlexWaygoodAlexWaygoodJul 24, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using a TypeVar here (and with the other functions in this PR), we can make the annotation much more expressive.

The annotation currently says "you put in an object f that's some subtype of type[CConverter], and you get out an object that's some subtype of type[CConverter].

The new annotation, by contrast, says, "you put in an object f, and you get out an object that has the same type as whatever the type of f is, as long as the type of f is a subtype of type[CConverter].

@AlexWaygoodAlexWaygoodJul 24, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example, with the following snippet:

x=add_c_converter(bool_converter)

Mypy would have inferred the type of x to be type[CConverter] with the current annotation. But with the new annotation, mypy should be able to infer that the type of x is bool_converter.

@erlend-aaslanderlend-aaslandJul 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

if not name:
name = f.__name__
if not name.endswith('_converter'):
Expand All@@ -2659,7 +2662,7 @@ def add_c_converter(
converters[name] = f
return f

def add_default_legacy_c_converter(cls):
def add_default_legacy_c_converter(cls: CConverterClassT) -> CConverterClassT:
# automatically add converter for default format unit
# (but without stomping on the existing one if it's already
# set, in case you subclass)
Expand All@@ -2670,16 +2673,19 @@ def add_default_legacy_c_converter(cls):

def add_legacy_c_converter(
format_unit: str,
**kwargs
) -> Callable[[ConverterType], ConverterType]:
**kwargs: Any
) -> Callable[[CConverterClassT], CConverterClassT]:
"""
Adds a legacy converter.
"""
def closure(f):
def closure(f: CConverterClassT) -> CConverterClassT:
added_f: Callable[..., CConverter]
if not kwargs:
added_f = f
else:
added_f = functools.partial(f, **kwargs)
# mypy's special-casing for functools.partial
# can't quite grapple with this code here
added_f = functools.partial(f, **kwargs) # type: ignore[arg-type]
if format_unit:
legacy_converters[format_unit] = added_f
return f
Expand Down