Skip to content

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13 - #107229

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:limited-capi-PyDict_GetItemRef
Jul 25, 2023
Merged

gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13#107229
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:limited-capi-PyDict_GetItemRef

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Jul 25, 2023

Copy link
Copy Markdown
Member

Comment threadInclude/dictobject.h Outdated
@vstinner

Copy link
Copy Markdown
Member

Oh sorry, I always forget to pay attention to versionning when adding a function to the limited C API.

@serhiy-storchakaserhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10Jul 25, 2023
@serhiy-storchakaserhiy-storchaka changed the title gh-106004: PyDict_GetItemRef() should only be in the limited API 3.10gh-106004: PyDict_GetItemRef() should only be in the limited API 3.13Jul 25, 2023
@serhiy-storchaka
serhiy-storchakaforce-pushed the limited-capi-PyDict_GetItemRef branch from 4210c15 to 6730eecCompareJuly 25, 2023 11:07

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@serhiy-storchaka
serhiy-storchaka merged commit 2b1a81e into python:mainJul 25, 2023
@serhiy-storchaka
serhiy-storchaka deleted the limited-capi-PyDict_GetItemRef branch July 25, 2023 18:48
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka@vstinner@bedevere-bot