Skip to content

[3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst - #107246

Merged
hugovk merged 1 commit into
python:3.11from
mattwang44:old-index-directives-in-library-imp
Jul 26, 2023
Merged

[3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst#107246
hugovk merged 1 commit into
python:3.11from
mattwang44:old-index-directives-in-library-imp

Conversation

@mattwang44

@mattwang44mattwang44 commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

I found the following message when building 3.11 doc:

Warning, treated as error:
'statement' is deprecated for index entries (from entry 'statement: import'). Use 'pair: statement; import' instead.

It's part of sphinx-doc/sphinx#11412 and was released with sphinx 7.1.0 yesterday.

@AA-Turner resolved most issues in #104162 (and its 3.11 backport PR is #104163). However, imp module was removed in 3.12 before that and the old index directive in library/imp.rst seems to be omitted.


📚 Documentation preview 📚: https://cpython-previews--107246.org.readthedocs.build/

@bedevere-botbedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 25, 2023
@mattwang44
mattwang44force-pushed the old-index-directives-in-library-imp branch from d1f419e to 9158f63CompareJuly 25, 2023 14:15
@mattwang44mattwang44 changed the title GH-97950: Use new-style index directive (Doc/library/imp.rst@3.11)GH-97950: Use new-style index directive in Doc/library/imp.rst@3.11Jul 25, 2023
@mattwang44mattwang44 changed the title GH-97950: Use new-style index directive in Doc/library/imp.rst@3.11[3.11] GH-97950: Use new-style index directive in Doc/library/imp.rstJul 25, 2023
@mattwang44mattwang44 changed the title [3.11] GH-97950: Use new-style index directive in Doc/library/imp.rst[3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rstJul 25, 2023
@mattwang44
mattwang44force-pushed the old-index-directives-in-library-imp branch from 9158f63 to 7c3d6aeCompareJuly 26, 2023 02:26
@AA-Turner

Copy link
Copy Markdown
Member

cc: @hugovk@ezio-melotti

@hugovkhugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @mattwang44 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.12

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.11

@hugovk

Copy link
Copy Markdown
Member

Ignore those two Miss Islington messages, this obviously doesn't need back porting to 3.12 and 3.11 branches because this went straight to 3.11 only.

Thanks again!

@hugovkhugovk removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
@hugovkhugovk removed their assignment Jul 26, 2023
@mattwang44
mattwang44 deleted the old-index-directives-in-library-imp branch July 26, 2023 06:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mattwang44@AA-Turner@miss-islington@hugovk@bedevere-bot