Uh oh!
There was an error while loading. Please reload this page.
gh-107082: Fix instruction size computation for ENTER_EXECUTOR - #107256
Merged
Conversation
bedevere-bot
commented
Jul 25, 2023
🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 92b493d 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
vstinner
commented
Jul 25, 2023
Member
I tested manually the change on ppc64. I confirm that this change fix I built Python with Without the fix, I am able to reproduce the issue. |
vstinner
approved these changes
Jul 25, 2023
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. The change retrieves the original opcode stored in executors by insert_executor().
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
commented
Jul 25, 2023
Member
Thanks for the fix. |
jtcave pushed a commit
to jtcave/cpython
that referenced
this pull request
Jul 27, 2023
…ython#107256) Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this fixes the big-endian buildbots it should also fixgh-107083.