Skip to content

gh-106368: Increase Argument Clinic CLI test coverage - #107277

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:clinic/more-cli-coverage
Jul 26, 2023
Merged

gh-106368: Increase Argument Clinic CLI test coverage#107277
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:clinic/more-cli-coverage

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jul 25, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

  • Add test case for directory traversal

  • Add test cases for invalid CLI option combinations.

@erlend-aasland
pythongh-106368: Increase Argument Clinic CLI test coverage
207fd5b
- Add test case for directory traversal
- Add test cases for invalid CLI option combinations.
@bedevere-botbedevere-bot mentioned this pull request Jul 25, 2023
Closed
@bedevere-botbedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 25, 2023
@erlend-aasland

erlend-aasland commented Jul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

With this PR, we're up in 88% coverage.

sobolevn
sobolevn approved these changes Jul 26, 2023
View reviewed changes
Comment threadLib/test/test_clinic.py
self.assertIn(msg, out)

def test_cli_fail_filename_or_output_and_make(self):
for opts in ("-o", "out.c"), ("filename.c",):

@sobolevnsobolevnJul 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit:

Suggested change
foroptsin ("-o", "out.c"), ("filename.c",):
foroptsin[("-o", "out.c"), ("filename.c",)]:

For me, this is much more readable.

@erlend-aasland
erlend-aasland merged commit 579100f into python:mainJul 26, 2023
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland
erlend-aasland deleted the clinic/more-cli-coverage branch July 26, 2023 06:34
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 579100f6d75a27429e7f8de74935d7bc3a3e44e6 3.11

@bedevere-bot

bedevere-bot commented Jul 26, 2023

Copy link
Copy Markdown

GH-107282 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
@erlend-aasland@miss-islington
pythongh-106368: Increase Argument Clinic CLI test coverage (pythonGH…
ff88620
…-107277)
(cherry picked from commit 579100f)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 26, 2023
@erlend-aasland

erlend-aasland commented Jul 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review!

erlend-aasland added a commit that referenced this pull request Jul 26, 2023
@miss-islington@erlend-aasland
[3.12]gh-106368: Increase Argument Clinic CLI test coverage (GH-107277…
ef80851
…) (#107282)
(cherry picked from commit 579100f)
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aaslanderlend-aasland added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 26, 2023
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 579100f6d75a27429e7f8de74935d7bc3a3e44e6 3.11

@bedevere-bot

bedevere-bot commented Jul 26, 2023

Copy link
Copy Markdown

GH-107326 is a backport of this pull request to the 3.11 branch.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 26, 2023
@erlend-aasland
[3.11]pythongh-106368: Increase Argument Clinic CLI test coverage (p…
483db97
…ython#107277)
(cherry picked from commit 579100f)
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2023
erlend-aasland added a commit that referenced this pull request Jul 26, 2023
@erlend-aasland
[3.11]gh-106368: Increase Argument Clinic CLI test coverage (#107277) (
9edeeb2
#107326)
(cherry picked from commit 579100f)
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@erlend-aasland@jtcave
pythongh-106368: Increase Argument Clinic CLI test coverage (python#1…
3935d5f
…07277)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes
@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees

@erlend-aaslanderlend-aasland

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@miss-islington@bedevere-bot@sobolevn