Skip to content

gh-107091: Fix some uses of :attr: role - #107318

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:docs-attr-role
Jul 27, 2023
Merged

gh-107091: Fix some uses of :attr: role#107318
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:docs-attr-role

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Jul 26, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchakaserhiy-storchaka added docs Documentation in the Doc dir skip news topic-C-API needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
@bedevere-botbedevere-bot mentioned this pull request Jul 26, 2023
Closed
vstinner
vstinner approved these changes Jul 26, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a minor suggestion.

Comment threadDoc/c-api/import.rst Outdated
Comment threadDoc/c-api/init.rst Outdated
Comment threadDoc/c-api/import.rst Outdated
@serhiy-storchaka
serhiy-storchaka merged commit d363eb5 into python:mainJul 27, 2023
@miss-islington

miss-islington commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the docs-attr-role branch July 27, 2023 05:52
@miss-islington

miss-islington commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d363eb5b0255c055e7b43f5e2c0847f555e1982e 3.12

@miss-islington

miss-islington commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d363eb5b0255c055e7b43f5e2c0847f555e1982e 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2023
@serhiy-storchaka
[3.12]pythongh-107091: Fix some uses of :attr: role (pythonGH-107318)
0553bcf
Fix also formatting of PyMethodDef members..
(cherry picked from commit d363eb5)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 27, 2023

Copy link
Copy Markdown

GH-107330 is a backport of this pull request to the 3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12 only security fixes label Jul 27, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 27, 2023
@serhiy-storchaka
[3.11]pythongh-107091: Fix some uses of :attr: role (pythonGH-107318)
bba26d3
Fix also formatting of PyMethodDef members..
(cherry picked from commit d363eb5)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 27, 2023

Copy link
Copy Markdown

GH-107331 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2023
@serhiy-storchaka
[3.12]gh-107091: Fix some uses of :attr: role (GH-107318) (GH-107330)
434e3b8
Fix also formatting of PyMethodDef members.
(cherry picked from commit d363eb5)
serhiy-storchaka added a commit that referenced this pull request Jul 27, 2023
@serhiy-storchaka
[3.11]gh-107091: Fix some uses of :attr: role (GH-107318) (GH-107331)
17aada0
Fix also formatting of PyMethodDef members.
(cherry picked from commit d363eb5)
@serhiy-storchakaserhiy-storchaka removed their assignment Sep 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip newstopic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka@miss-islington@bedevere-bot@vstinner